[WIP] 🐛 fix local installation #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost#368 - if you run `ghost start`, the CLI will spawn a detached process - this detached process will spawn another process - the `cp.pid` was wrong in any case - forward the pid from the spawned process back to parent process
|
Closing because this isn't the right solution - and won't work on windows because it relies on IPC messaging to do things correctly, which doesn't work in Windows |
|
Well, as it turns out windows does support ipc messaging - meaning the changes in the previous pr (#366) were wrong 😅 . However, this is still not the right approach. |
|
sorry wrong button :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #368
if you run
ghost start, the CLI will spawn a detached processthis detached process will spawn another process
the
cp.pidwas wrong in any caseforward the pid from the spawned process back to parent process
test on mac
test on windows
test on linux