Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(process-manager): allow process isRunning to return a promise #669

Merged
merged 1 commit into from
Mar 14, 2018
Merged

feat(process-manager): allow process isRunning to return a promise #669

merged 1 commit into from
Mar 14, 2018

Conversation

acburdine
Copy link
Member

@acburdine acburdine commented Mar 13, 2018 •
edited
Loading

refs #668

  • update instance.running() to handle process.isRunning promise
  • update everywhere that uses instance.running to handle the promise

TODO:

  • tests

Reasoning

@acburdine
feat(process-manager): allow process isRunning to return a promise
d326d66 
refs TryGhost#668
- update instance.running() to handle process.isRunning promise
- update everywhere that uses instance.running to handle the promise
- fix tests
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d326d66 on acburdine:feat/promises-everywhere into cb2e3d0 on TryGhost:master.

vikaspotluri123
vikaspotluri123 approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@vikaspotluri123 vikaspotluri123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

aileen
aileen approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@aileen aileen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I wasn't able to break it 👍

@aileen aileen merged commit 29b4a0b into TryGhost:master Mar 14, 2018
@aileen aileen mentioned this pull request Mar 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aileen aileen aileen approved these changes

@vikaspotluri123 vikaspotluri123 vikaspotluri123 approved these changes

@kirrg001 kirrg001 Awaiting requested review from kirrg001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acburdine @coveralls @vikaspotluri123 @aileen