-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run isRunning
and isEnabled
as sudo
#672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
So the isRunning part looks good, however the I'll work on updating the isEnabled code as well, which should make this PR work as expected, but wanted to comment here first so it doesn't get merged before that's been done 😉 Edit: #674 has the other changes required for this PR to work. |
refs TryGhost#672 - support isEnabled returning a promise
refs #672 - support isEnabled returning a promise
84727f3
to
df0bce1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally, works great :) thanks!
closes #660
refs #414
Recently there were many users reporting issues when the CLI is running the command
systemctl is-active
. With the changes in #669 we are now able to run theisRunning
andisEnabled
methods in our systemd extension, as those were the only commands that weren't executed assudo
.Manual tests worked fine for me. I can't say if it'll fix all the issues, as I wasn't able to reproduce the issues on the recommended stack. Nevertheless, there were enough reports of this issue actually happening on the recommended stack.