Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(process): allow process.isEnabled to return a promise #674

Merged
merged 1 commit into from
Mar 19, 2018
Merged

feat(process): allow process.isEnabled to return a promise #674

merged 1 commit into from
Mar 19, 2018

Conversation

acburdine
Copy link
Member

refs #672

  • support isEnabled returning a promise

@acburdine
feat(process): allow process.isEnabled to return a promise
b896d02 
refs TryGhost#672
- support isEnabled returning a promise
@acburdine acburdine mentioned this pull request Mar 18, 2018
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b896d02 on acburdine:feat/isenabled-promise into 29b4a0b on TryGhost:master.

aileen
aileen reviewed Mar 19, 2018
View reviewed changes
Copy link
Member

@aileen aileen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aileen aileen merged commit c93124b into TryGhost:master Mar 19, 2018
@acburdine acburdine deleted the feat/isenabled-promise branch March 19, 2018 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aileen aileen aileen left review comments

@kirrg001 kirrg001 Awaiting requested review from kirrg001

@vikaspotluri123 vikaspotluri123 Awaiting requested review from vikaspotluri123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acburdine @coveralls @aileen