-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Comparing changes
Open a pull request
base repository: TryGhost/Ghost
base: v5.89.6
head repository: TryGhost/Ghost
compare: v5.90.0
Commits on Aug 16, 2024
-
🐛 Fixed a bug causing new drafts to only save if the title is populat…
…ed (#20769) ref https://linear.app/tryghost/issue/ONC-253/drafts-only-save-if-the-title-is-populated - A [commit](c8ba9e8) in `v5.89.1` introduced a bug that caused new drafts to only save if the post title was populated, causing potential data loss if a user is working on a new draft without setting the title. - This commit reverts the one that introduced this bug to prevent data loss. This reverts commit c8ba9e8.
Configuration menu - View commit details
-
Copy full SHA for 77b1891 - Browse repository at this point
Copy the full SHA 77b1891View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4794a5 - Browse repository at this point
Copy the full SHA f4794a5View commit details
Commits on Aug 19, 2024
-
Fixed draft posts not autosaving without title (#20774)
ref [ENG-661](https://linear.app/tryghost/issue/ENG-661/) ONC-253 - Reverts the revert of 93cbb94 of the intial bug fix. - Updated hasDirtyAttributes logic to ensure the dirty state changes when typing a draft, despite not title. - Updated tests and added tests missing from the hasDirtyAttributes logic
Configuration menu - View commit details
-
Copy full SHA for aad438b - Browse repository at this point
Copy the full SHA aad438bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4462b20 - Browse repository at this point
Copy the full SHA 4462b20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a7b8bd - Browse repository at this point
Copy the full SHA 6a7b8bdView commit details -
Revert "Fixed draft posts not autosaving without title (#20774)" (#20776
) This reverts commit aad438b. - reverts the commit so that we can merge it together with PLG-174
Configuration menu - View commit details
-
Copy full SHA for 6ebcd10 - Browse repository at this point
Copy the full SHA 6ebcd10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f76847 - Browse repository at this point
Copy the full SHA 2f76847View commit details -
Publish flow Close button improvements (#20779)
fixes https://linear.app/tryghost/issue/DES-682/close-button-improvements Small updates to the modal in the new Publish flow. Improved margins and opacity for legibility.
Configuration menu - View commit details
-
Copy full SHA for f864bde - Browse repository at this point
Copy the full SHA f864bdeView commit details -
Adds blur behind 'Share' modal (#20782)
fixes https://linear.app/tryghost/issue/DES-683/add-blur-behind-modal Adds a blur behind the modal in the new Publish flow.
Configuration menu - View commit details
-
Copy full SHA for 1e3edc0 - Browse repository at this point
Copy the full SHA 1e3edc0View commit details -
Fix browser tests for Radix migration (#20783)
DES-696 We upgraded the AdminX Design System to use Radix UI components. However browser tests fail for checkboxes at the moment which must be fixed for release.
Configuration menu - View commit details
-
Copy full SHA for d66a0e3 - Browse repository at this point
Copy the full SHA d66a0e3View commit details -
🐛 Fixed autosave not triggering when in-editor excerpt is changed (#2…
…0785) ref https://linear.app/tryghost/issue/PLG-174 - added `blur` handler to excerpt field so it acts the same as the title field and triggers a save when it loses focus
Configuration menu - View commit details
-
Copy full SHA for 21aa1b4 - Browse repository at this point
Copy the full SHA 21aa1b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26724d8 - Browse repository at this point
Copy the full SHA 26724d8View commit details -
Updated Admin editor unit tests to use real model instances
ref https://linear.app/tryghost/issue/PLG-176 - we recently had to revert code because it caused unexpected problems despite the unit tests passing - the setup for the editor unit tests was very basic and did not represent the real world because it tested a simple EmberObject instance rather than an Ember Model instance meaning the tests weren't covering the real code paths - updated the unit test with a more realistic environment ready for re-working the reverted code+tests
Configuration menu - View commit details
-
Copy full SHA for 64fbf3b - Browse repository at this point
Copy the full SHA 64fbf3bView commit details -
🐛 Fixed editor unsaved changes modal showing too often (#20787)
ref [ENG-661](https://linear.app/tryghost/issue/ENG-661/) ref [ONC-253](https://linear.app/tryghost/issue/ONC-253/) ref [PLG-174](https://linear.app/tryghost/issue/PLG-174/) - restored the original but reverted fix for unsaved changes modal from #20687 - updated code to remove some incorrect early-falsy-return logic in `editorController.hasDirtyAttributes` that prevented save of unsaved changes on the underlying model (e.g. excerpt) - updated unit tests so they are testing real post model instances and therefore are testing what we expect them to test - added acceptance tests to ensure autosave is working for title and excerpt fields --------- Co-authored-by: Ronald Langeveld <hi@ronaldlangeveld.com>
Configuration menu - View commit details
-
Copy full SHA for 887f4d3 - Browse repository at this point
Copy the full SHA 887f4d3View commit details -
Fixed excerpt blur saving non-draft posts
ref https://linear.app/tryghost/issue/PLG-174 - forcing autosave on excerpt blur caused posts to revert to `draft` and save immediately even when they were published/scheduled - updated the save-on-excerpt-blur to only autosave drafts - added acceptance tests for title and excerpt change+blur on published posts
Configuration menu - View commit details
-
Copy full SHA for 9dfbd3e - Browse repository at this point
Copy the full SHA 9dfbd3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f4bc9c - Browse repository at this point
Copy the full SHA 9f4bc9cView commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0a2f2ad - Browse repository at this point
Copy the full SHA 0a2f2adView commit details -
Added default background and font styles to cards (#20676)
ref DES-609 - On top of bookmark card, this update adds default background color and font to file, audio, and product cards - The main purpose of this is keeping embedded look across these cards consistencly regardless of the theme background color and default font - Themes can still override the styles
Configuration menu - View commit details
-
Copy full SHA for cc545b5 - Browse repository at this point
Copy the full SHA cc545b5View commit details -
Share button improvements on publish flow modal (#20791)
ref DES-684 - switched social links from buttons to regular links - added post title to share links
Configuration menu - View commit details
-
Copy full SHA for 5cce46e - Browse repository at this point
Copy the full SHA 5cce46eView commit details -
Changed color of adminX prefix for
yarn dev
- red makes it look like an error, which is very misleading - I've changed this to a random purple I found - credits to @vershwal and @dvdwinden
Configuration menu - View commit details
-
Copy full SHA for 0f3805e - Browse repository at this point
Copy the full SHA 0f3805eView commit details -
Updated tips & donations default suggested value
closes https://linear.app/tryghost/issue/PLG-156 - updated all default fixtures to use `500` ($5) as the default suggested donation value - added migration to update existing settings using the old default of `0` to `500` - this is fine to apply because the feature hasn't been released so there's no explicit `0` values in the wild - added an acceptance test for the adminx-settings tips & donations section
Configuration menu - View commit details
-
Copy full SHA for 0b3f7d7 - Browse repository at this point
Copy the full SHA 0b3f7d7View commit details -
Updated donations browser tests for new default suggested value
ref #20793 - now that there's a non-zero suggested value amount Stripe's UI shows a button to change the amount rather than showing the amount input field immediately - added extra click to the tests and an expectation that the default value is set correctly
Configuration menu - View commit details
-
Copy full SHA for d3c2c7b - Browse repository at this point
Copy the full SHA d3c2c7bView commit details -
Improved publish flow transition (#20794)
ref DES-697 - used client side navigation on the flow instead of hard refresh - reduced layout shift on the analytics screen - made the modal transition a bit smoother
Configuration menu - View commit details
-
Copy full SHA for a8dc689 - Browse repository at this point
Copy the full SHA a8dc689View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b41307 - Browse repository at this point
Copy the full SHA 9b41307View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6413a30 - Browse repository at this point
Copy the full SHA 6413a30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5effca4 - Browse repository at this point
Copy the full SHA 5effca4View commit details -
Added donation notification toggle to user settings
closes https://linear.app/tryghost/issue/PLG-155 - added checkbox when "stripe enabled" check is true
Configuration menu - View commit details
-
Copy full SHA for 2712384 - Browse repository at this point
Copy the full SHA 2712384View commit details -
Fixed email integration tests (#20799)
ref dac2561 Among the mess of GH forks, it seems a few commits got lost patching up these tests.
Configuration menu - View commit details
-
Copy full SHA for 2f36d6a - Browse repository at this point
Copy the full SHA 2f36d6aView commit details -
✨ Updated email analytics job to prioritize open events (#20800)
ref https://linear.app/tryghost/issue/ENG-1477 - updated email analytics job to prioritize open events - put limits on non-open event fetching - updated job to now restart itself until processing is at a sufficiently low volume Previously the EmailAnalytics job would process all event data equally. When there's sufficient recipients (>20k), we could see delays in the open rate data in Admin because of all the delivered events being processed. Open events are far more important to users, so we've now prioritized processing those events before any others. Processing of events shouldn't be any faster or slower with this as this doesn't change throughput, just order. NOTE: Use the mailgun-mock-server in TryGhost/Toolbox for testing.
Configuration menu - View commit details
-
Copy full SHA for 4267ff9 - Browse repository at this point
Copy the full SHA 4267ff9View commit details -
Fixed value destructuring for null values (#20803)
ref 4267ff9 Found while testing other code. Appears to fail destructuring which prevents the job from running.
Configuration menu - View commit details
-
Copy full SHA for 8e1f552 - Browse repository at this point
Copy the full SHA 8e1f552View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c9b8d6 - Browse repository at this point
Copy the full SHA 3c9b8d6View commit details -
Added additional tests for email analytics (#20805)
ref 4267ff9 - unit tests didn't cover what events were passed along to be fetched, important now that it's split out
Configuration menu - View commit details
-
Copy full SHA for 54b0b87 - Browse repository at this point
Copy the full SHA 54b0b87View commit details
Commits on Aug 21, 2024
-
🐛 Fixed editor performance issues in Safari for posts with HTML or Ma…
…rkdown cards (#20806) ref https://linear.app/tryghost/issue/ONC-261 - Previous method of hiding the second Lexical instance using `width: 0`, `height: 0`, and `overflow: hidden` caused CPU usage to spike, likely due to CodeMirror continuously processing the element.
Configuration menu - View commit details
-
Copy full SHA for 3645fd8 - Browse repository at this point
Copy the full SHA 3645fd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2627dd6 - Browse repository at this point
Copy the full SHA 2627dd6View commit details -
Fixed editor not loading in Admin acceptance tests
closes https://linear.app/tryghost/issue/PLG-176 The editor files were previously stubbed for testing because we didn't have a way to load the externally-hosted files. This made testing slow and difficult because the only way to test the Admin integration was via Ghost's e2e browser tests. - unstubbed the editor globals so `fetchKoenigLexical()` actually tries to import the external assets - updated `ember-cli-build` to copy the Koenig UMD file over to the assets directory in development/test builds - updated `environment.js` to set the required filename for the default asset import to successfully hit the test environment hosted files - updated lexical editor acceptance tests to demonstrate the editor loads successfully for new and existing posts
Configuration menu - View commit details
-
Copy full SHA for fc501ad - Browse repository at this point
Copy the full SHA fc501adView commit details -
Fixed Admin test failures when running in Safari
no issue - Safari's `innerText` sometimes includes a trailing `\n` depending on the markup used so we need to use `.to.have.rendered.trimmed.text()` - reproducible when running tests via http://localhost:4200/tests (we don't yet run in Safari via our testem config)
Configuration menu - View commit details
-
Copy full SHA for b01d428 - Browse repository at this point
Copy the full SHA b01d428View commit details -
Hid tips and donation settings when Stripe is disabled
closes https://linear.app/tryghost/issue/PLG-178 - updated conditional to ensure we're ready for GA by showing when Stripe is enabled rather than only when the feature flag is enabled
Configuration menu - View commit details
-
Copy full SHA for f08e4d4 - Browse repository at this point
Copy the full SHA f08e4d4View commit details -
🐛 Fixed frontend routing prioritizing collections over built in routes (
#20765) ref https://linear.app/tryghost/issue/ONC-242/frontend-routing-prioritizes-collections-over-taxonomies - Under a fairly specific edge case with a collection route that conflicts with a default, built-in route ("taxonomy" — like tags, authors, etc), the frontend routing would prioritize the collection over the taxonomy. - For example, with the following in a custom `routes.yaml`: ``` collections: /: permalink: /{primary_tag}/{slug}/ template: index ``` If a post exists with the same slug as its primary tag's slug, the frontend routing would redirect the `/tag/{slug}/` route to the post in the collection, rather than serving the tag itself. - This commit changes that, so if a collection's route conflicts with e.g. a `/tag/{slug}/` default route, Ghost will still return the built in route, rather than the collection.
Configuration menu - View commit details
-
Copy full SHA for c0471f0 - Browse repository at this point
Copy the full SHA c0471f0View commit details -
🔒 Fixed admin forms defaulting to GET method (#20810)
ref https://linear.app/tryghost/issue/ENG-1497/admin-signin-signup-and-setup-forms-default-to-get - If method is not specified, the form will default to GET, which is incorrect - This commit sets the method to POST and action to javascript:void(0) to prevent the form from submitting via GET if JavaScript is disabled or not fully loaded yet
Configuration menu - View commit details
-
Copy full SHA for 6d46dc2 - Browse repository at this point
Copy the full SHA 6d46dc2View commit details
Commits on Aug 22, 2024
-
Ref [ONC-216](https://linear.app/tryghost/issue/ONC-216/improve-the-performance-of-the-membersevents-aggregated-click-event) Needed changes in nql package for this task.
Configuration menu - View commit details
-
Copy full SHA for 309cb37 - Browse repository at this point
Copy the full SHA 309cb37View commit details -
Added i18n support to tips and donations on portal (#20812)
ref PLG-159 - wrapped strings inside the translate function in Portal - added new strings to i18n files
Configuration menu - View commit details
-
Copy full SHA for ad3751b - Browse repository at this point
Copy the full SHA ad3751bView commit details -
Added one-time payments under "payments" for filtering (#20807)
ref PLG-153 - Scoped one-time payments (`donation_event`) under the "payments" category in the member activity feed filter. - Updated `toggleEventType` logic to ensure that toggling "payments" also toggles one-time payments when the `tipsAndDonations` feature is enabled. - Refactored event type handling into utility functions for easier testing. - Added unit tests for the new utility functions to ensure correct behaviour. - Added acceptance testing.
Configuration menu - View commit details
-
Copy full SHA for f2206fb - Browse repository at this point
Copy the full SHA f2206fbView commit details -
🎨 Improved the performance of the /members/events/ aggregated_click_e…
Configuration menu - View commit details
-
Copy full SHA for f984fbd - Browse repository at this point
Copy the full SHA f984fbdView commit details -
🐛 Fixed fetching labels and offers in the editor (#20815)
ref https://linear.app/tryghost/issue/ONC-263/ - labels dropdown in sign up card was not successfully fetching labels - offers dropdown suffered the same fate When introducing the second editor instance, it appears we ran into some race conditions with the Ember tasks used to fetch the resources. The init instance was beating the other to the punch, and so the state was never successfully updated, as it is only fetched once on mounting the card.
Configuration menu - View commit details
-
Copy full SHA for cd7c27d - Browse repository at this point
Copy the full SHA cd7c27dView commit details -
Publish modal updates (#20817)
The new modal for the updated publishing flow has an entirely new layout, based on feedback previously received. In addition, this PR includes a few tweaks to the underlying logic.
Configuration menu - View commit details
-
Copy full SHA for 7c99282 - Browse repository at this point
Copy the full SHA 7c99282View commit details -
🐛 Fixed shift selection in the posts list (#20818)
ref https://linear.app/tryghost/issue/ENG-1489/ The changes to improve posts loading in admin broke the shift selection functionality. This restores that, as we need to be able to crawl across the (now) three models when present.
Configuration menu - View commit details
-
Copy full SHA for 827518c - Browse repository at this point
Copy the full SHA 827518cView commit details -
✨ Improved email analytics jobs system (#20809)
ref https://linear.app/tryghost/issue/ENG-952 - added persistence to the job timestamps This set of changes reduces the potential for gaps in our email event processing by adding persistence to the job timestamps. This avoids expensive queries on the `email_recipients` table after every boot, and reduces reliance on fallbacks in periods of heavy processing or reboot. This is our first use of the jobs table to create a persistent line, instead of its initial use case of single-run jobs. We may expand this capability and move to use of the jobs model over knex.raw in order to make this a bit friendlier. Note: this works with sqlite but datetimes are stored as ints. It still works fine. knex/knex#5272
Configuration menu - View commit details
-
Copy full SHA for 0053939 - Browse repository at this point
Copy the full SHA 0053939View commit details -
Added integrity token API & middleware for magic link requests
ref KTLO-1 Back-end implementation of request integrity tokens. The purpose here is to prevent simple web bots from spamming the signup form.
Configuration menu - View commit details
-
Copy full SHA for a48b4e5 - Browse repository at this point
Copy the full SHA a48b4e5View commit details -
Added support in Portal for integrity tokens on magic link API
ref KTLO-1 These tokens should prevent untargeted attacks, as the magic link endpoint needs a token that was generated by the server, similar to a CSRF token, but without needing any server-side state, or a cookie to be set for unauthenticated users.
Configuration menu - View commit details
-
Copy full SHA for ef4f793 - Browse repository at this point
Copy the full SHA ef4f793View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebc8700 - Browse repository at this point
Copy the full SHA ebc8700View commit details
There are no files selected for viewing