No pubDate for RSS messes up etags for the feed

[andris9]

RSS module takes an optional property pubDate which is used for <lastBuildDate> header in the RSS XML. Ghost does not provide this value and current time is used by default. This in turn messes up HTTP response ETag headers – as the RSS feed seems to be "different" a new ETag is generated for every request. Thus If-None-Match requests do not work. Making ETags work properly would make it possible to return an empty 304 response to such query instead of the full RSS feed.

Proposed solution: use the date of the newest message as pubDate for the feed.

[halfdan]

@andris9 Not really sure about that, but looking at our RSS feed from Ghostalk, Ghost does provide the lastBuildDate in the header: https://talk.ghost.io/rss/

It is even taken from the date of the most recent post.

What version are you running?

[shindakun]

@halfdan Does appear to occur on self hosted running tag 0.4.2, as I can see my site doing the same. I'm at work so I can't dig much further at the moment. I'll dig into a bit further in a couple of hours though.

[shindakun]

I looked further anyway lol, shhh https://github.com/dylang/node-rss/blob/master/lib/rss.js#L75

[halfdan]

Right, so most of that is going to be fixed once I ship my own RSS library
:-/ Not sure what to do about it in the meantime.
On 17 May 2014 00:35, "Steve Layton" notifications@github.com wrote:

I looked further anyway lol, shhh
https://github.com/dylang/node-rss/blob/master/lib/rss.js#L75

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2777#issuecomment-43389988
.

[shindakun]

@halfdan Rushed release of your library? j/k Any idea what they are using on the hosted site? (Or is it your library?)

[halfdan]

Hosted is cached by cloudflare. My library isn't close to done yet - will
have to spend some extra hours on it to get it into a state where it's good
enough to replace node-rss.
On 17 May 2014 01:00, "Steve Layton" notifications@github.com wrote:

@halfdan https://github.com/halfdan Rushed release of your library? j/k
Any idea what they are using on the hosted site? (Or is it your library?)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2777#issuecomment-43391097
.

[ErisDS]

@halfdan

[JohnONolan]

Should be addressed in #2263

[ErisDS]

Going to close this against #2263 as there seems little point in having both issues open.

[ErisDS]

#3993 should get this resolved