-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove authentication for public endpoints #4181
Comments
Very interested in getting this going any help needed here? |
Latest blog comments plugin for NodeBB seems to rely on these routes to be publically accessible, so that particular plugin is no longer compatible with v0.5 👍 for this issue. |
👍 from me as well. There are workaround to making the routes publically -- Serban Constantin On Wed, Oct 8, 2014 at 12:52 AM, Julian Lam notifications@github.com
|
There's a big chain of dependencies here starting with #3910 but we'd absolutely love someone to get stuck in and give us a hand. |
Cool. I have a first pass as what I think might be a good solution I'll solicit feed back in the coming week hopefully. |
@jrayaustin Feel free to put up a PR with [WIP] prefixing the title if you to claim this even while you're working things out =) |
Will do! @novaugust |
You guys can monitor the progress for this #4251 |
refs TryGhost#4180 closes TryGhost#4181 - added client and user authentication - added authenticatePublic/authenticatePrivate as workaround for missing permissions - added domain validation - added CORS header for valid clients - merged authenticate.js and client-auth.js into auth.js - removed middleware/api-error-handlers.js - removed authentication middleware - added and updated tests
This belongs to the OAuth Epic: #4004 - please read this for the big picture of what this issue is for :)
Requires: #4179 and #4180
The authorization method needs to be changed to allow access to the following API endpoints without requiring authentication:
GET /ghost/api/v0.1/posts/
(status == published)GET /ghost/api/v0.1/posts/<id>
(status == published)GET /ghost/api/v0.1/posts/slug/<slug>
(status == published)GET /ghost/api/v0.1/tags/
GET /ghost/api/v0.1/settings/
(type == blog)GET /ghost/api/v0.1/settings/<key>
(type == blog)GET /ghost/api/v0.1/users/<id>
GET /ghost/api/v0.1/users/slug/<slug>
GET /ghost/api/v0.1/users/email/<email>
While implementing this issue it would be good to investigate if it is possible to do the authentication only if a bearer token is available in the request body and let
canThis()
deny access if authentication is required.Attention: Third party access to public endpoints should not be allowed before all permissions are in place (#3911).
The text was updated successfully, but these errors were encountered: