Replace anchors with no real href with buttons #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,7 +12,7 @@ | |||
| {{#link-to "editor.edit" this class="post-edit" title="Edit Post"}} | |||
| <span class="hidden">Edit Post</span> | |||
| {{/link-to}} | |||
| {{#gh-popover-button popoverName="post-settings-menu" tagName="a" classNames="post-settings" title="Post Settings"}} | |||
| {{#gh-popover-button popoverName="post-settings-menu" tagName="button" classNames="post-settings" title="Post Settings"}} | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
ErisDS
added a commit
that referenced
this pull request
Jul 15, 2014
Replace anchors with no real href with buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3101 & #916
Important: As soon as this is merged, I need to tag & release a new version of Ghost-UI, as these changes may make things look rather broken without the amended styles.
Related style changes are https://github.com/TryGhost/Ghost-UI/commit/6ec8e26d8f5c3d7975d8900b8a810d3fde922418