Auto-save changes

[jaswilli]

Refs #4259

• Auto-save new post when title loses focus.
• If a post has '(Untitled)' for a title, regenerate slugs
  on all title changes--same behavior as a new post that does
  not yet have a slug.

[novaugust]

👍

[jaswilli]

Unfortunately the test failures are real. It's the auto-saving on focus-out that's doing it. In the tests, there are a bunch of "go to the editor and then make sure we're at the right URL" assertions. Casper is triggering a focus out on the title and then the route transitions and the URL changes.

Not sure what to do about that other than adapting the tests to be ok with /ghost/editor/ and /ghost/editor/<post id>/.

[JohnONolan]

One more bug, I think, populating the title field with (untitled) is breaking the focus on the body.

So:

1. Focus on title
2. Press Tab
3. Focus (very briefly) goes to body
4. Title populates with "(Untitled)"
5. Focus from body is lost

[ErisDS]

@jaswilli the changes to the tests sound fine ;)

[jaswilli]

I'm going to give it a shot. I have a bad feeling that if focus out is always triggered that it's going to cause a bunch of other tests to fail as well. I guess we'll find out.

[ErisDS]

So the problem with the editor losing focus is much bigger than it might first appear.

It's nothing to do with the introduction of autosave, however the change to making autosave happen when the title loses focus is causing this bug to become much, much more apparent than it is in Ghost at present.

Try the following:

1. start a new post
2. enter a title right away
3. Start typing a little in editor
4. press cmd/ctrl+s whilst you're typing to initialise a save much like autosave.

You'll notice you lose your focus. This happens no-matter-what on the initial save because of the transition from /ghost/editor/ to /ghost/editor/:id. It does not happen on any subsequent save.

This change to triggering that initial save on defocus of the title field makes this really super obvious because the defocus now happens just as you try to focus and start typing, rather than it happening as a result of you pressing cmd/ctrl+s (which is jarring) or pressing the button (if you press the button you defocus anyway).

I don't know what a solution to this might look like - we can't be the first people to have experienced this so perhaps there is a nice way to restore the correct focus after a transition? Alternatively as we now know the initial save will now always happen on defocus of the title we could have the 'edit' form of the editor always load with focus in the editor same as the 'new' one loads with focus in the title area - but I think that might still provide a jarring experience.

The tests are currently highlighting this issue I think - because some of the keys don't get sent to the correct location because of the focus being messed around with.

Is there any way to transition the route without reloading the editor part of the template?

[ErisDS]

By the way - I've been working on this for a few hours and almost have it all straightened out including tests

[jaswilli]

Awesome! Do you want me to back out the changes to the tests?

[ErisDS]

So there are a couple of pretty major bugs with the suggested idea of autosave-once on focusOut of the title field - namely that if you type a title and hit save there's a great big horrible error (which I think is why that particular test was failing) and also, if you open the editor and then navigate somewhere else you end up with an (Untitled) draft with nothing in it.

Soooo.... rather than doing autosave-once (or autosave if new) when focusing out from the title, I've moved it to when focusing into the codemirror textarea. So if you hit tab or click to edit, the route transition happens then.

I've also changed the edit route such that when you load it, focus is in the editor. This seems to work ok.

This means that the one case where you won't get an autosave is if you go straight from the title to the tags and add a tag. If you enter a title and/or tags and then try to navigate away you still get the nag-to-save.

As soon as you go to start creating content, you get an autosave, which I think is reasonably nice.

[novaugust]

That all sounds good to me. Just as a note, you can probably just update the if logic right here if you want to keep saving on title focus-out. Just assert that it actually has a title or some other change

if (this.get('isNew') && this.get('isDirty'))

//or

if (this.get('isNew') && this.get('titleScratch')) //the user typed something into the title bar

[jaswilli]

👍

I was going to propose doing it that way as working off the title was just too problematic.

If you have it sorted feel free to close this and open a new PR. 💃

[ErisDS]

I've got a new PR (#4307) open with your commit + my own. grunt test-functional --target=client/editor_test.js passed for me locally but still fails on travis so I'm going to play with the tests a little more.