Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autosave is overly ambitious #4321

Closed
novaugust opened this issue Oct 22, 2014 · 6 comments
Closed

Autosave is overly ambitious #4321

novaugust opened this issue Oct 22, 2014 · 6 comments
Assignees
@novaugust
Labels
affects:admin Anything relating to Ghost Admin
Milestone
Current Backlog

Comments

@novaugust
Copy link
Contributor

Issue Summary

If I open a new post and click in the editor, I find myself with a new post with the title "(Untitled)"

Why save a post that doesn't have any content in it? Now I'm cleaning out extra "(Untitled)" drafts whenever I decide I'm not going to write a post after all.

Repro Steps

  1. New Post
  2. Sit for a few seconds
  3. Click in the editor
  4. You've just saved your post!

Specs

Ghost 0.5.3 (Ghost Pro)
Chrome 38
@jaswilli
Copy link
Contributor

That's by design. See #4305 for the background.

@novaugust
Copy link
Contributor Author

Well... dang.
It just feels really awkward as a user, though. I haven't even typed anything; there's nothing to save! But now I have to delete it if I move on.

@PaulAdamDavis
Copy link
Member

I've not had a chance to check this out yet, but it would be annoying to have a plethora of saved drafts with nothing in them other than a title of '(Untitled)'

The UX and ambition of this can be refined much more.

@ErisDS
Copy link
Member

ErisDS commented Oct 22, 2014

This was one of the 'amendments' I referred to in the meeting yesterday - essentially, if the user navigates away from the editor when a post is saved in this state:

  • title is (Untitled)
  • content is empty

then we should remove it again.

I believe this is possible using willTransition ?

Whilst this may lead to a few blank posts being created, I don't think it's that big a deal. Too much save > too little save.

@novaugust novaugust mentioned this issue Oct 28, 2014
Merged
novaugust added a commit to novaugust/Ghost that referenced this issue Oct 29, 2014
@novaugust
Delete empty posts when leaving editor route
c965792 
Closes TryGhost#4321
- Renamed editor-route-base to editor-base-route to fit the naming scheme of editor-base-view and editor-base-controller
- Moved duplicate willTransition functionality from editor/edit and editor/new to editor-base-route
- editor-base-route passes willTransition actions up the route chain
- EditorRoute deletes a post with no bodyScratch and a title of `(Untitled)` on willTransition
@novaugust novaugust mentioned this issue Oct 29, 2014
Closed
novaugust added a commit to novaugust/Ghost that referenced this issue Oct 29, 2014
@novaugust
Delete empty posts when leaving editor route
4ac9e15 
Closes TryGhost#4321
- Renamed editor-route-base to editor-base-route to fit the naming scheme of editor-base-view and editor-base-controller
- Moved duplicate willTransition functionality from editor/edit and editor/new to editor-base-route
- editor-base-route passes willTransition actions up the route chain
- EditorRoute deletes a post with no bodyScratch and a title of `(Untitled)` on willTransition
@ErisDS ErisDS added the affects:admin Anything relating to Ghost Admin label Nov 3, 2014
@ErisDS ErisDS modified the milestones: Next Backlog, Current Backlog Nov 3, 2014
@ErisDS ErisDS assigned nicoburns and novaugust and unassigned nicoburns Nov 3, 2014
@novaugust
Copy link
Contributor Author

Odd notes to myself I dug out on a new try at this. Sorry for keeping my mess in public, but I'd lose it anywhere else - too many balls in the air this week

  1. Autofills "(Untitled)" in the post's title bar if you focus-out it while it's empty
  2. Removes the save-on-focus-in in the markdown or just doesn't call save from autosave if title is (Untitled) and there's no scratch

@novaugust novaugust mentioned this issue Nov 4, 2014
Closed
@ErisDS ErisDS mentioned this issue Nov 5, 2014
Closed
novaugust added a commit to novaugust/Ghost that referenced this issue Nov 7, 2014
@novaugust
Don't autosave on focus-in to editor
73b8ce8 
Closes TryGhost#4321
- Added a PostTitleInputComponent that sets its value to "(Untitled)" if it has no value on focusOut, and selects its text if its text is "(Untitled)" on a click.
- Posts have a default title, '(Untitled)'
- Removed autoSaveNew action firing onFocusIn of the markdown editor
- emberified the gh-trim-focus-input
- editor-base-controller is no longer responsible for setting a default title (horay!)
- Remove pause for autosave from functional-test helper "writeContentToCodeMirror"
@novaugust novaugust mentioned this issue Nov 16, 2014
Merged
@novaugust
Copy link
Contributor Author

We haven't had any user reported issues with this; closing :)

@grnd grnd mentioned this issue Mar 7, 2021
Open
@snyk-bot snyk-bot mentioned this issue Mar 27, 2022
Open
@amgir amgir mentioned this issue May 13, 2024
Open
@mdno mdno mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novaugust novaugust

Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Milestone
Current Backlog
5 participants
@ErisDS @jaswilli @PaulAdamDavis @nicoburns @novaugust