Fix high latency autosave bug in editor.new #4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TravisBuildNotPassedDerpNeedsMoreEqualsException 😜 |
novaugust
force-pushed
the
slow-save-errors#4400
branch
2 times, most recently
from
19af594 to
24fed69
Compare
Closes TryGhost#4400 - Added focusCursorAtEnd property to codemirror component, to set the cursor at document end on load. Used for posts that have been edited - centralized codemirror init code in component
novaugust
force-pushed
the
slow-save-errors#4400
branch
from
24fed69 to
a9ce31f
Compare
|
Updated, no more cursor position bug, and derps underped. |
|
Testing using yosemite chrome, the problem is consistent on master. This PR fixes it up and makes it work muuuch more smoothly. Do like 👍 |
ErisDS
added a commit
that referenced
this pull request
Nov 17, 2014
Fix high latency autosave bug in editor.new
|
In other news, whilst this fixes autosave in the |
|
|
ErisDS
added a commit
to ErisDS/Ghost
that referenced
this pull request
Nov 17, 2014
ref TryGhost#4459 - move initMarkers back to its original home - add new test that a post with an image can be edited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4400
Known bug: If you have typed into the body before the transition, after the transition completes your cursor is reset to the start of the line.
I've tried fixing this by having codemirror intelligently
goToDocEndafter being initialized, but it instead places it halfway. I'm still working on a fix for that. I'm not sure what's the greater evil; 4400 or the one-time cursor jump.The problem comes from the fact that the entire template is torn down and rebuilt, even though nothing actually changes. I think that the ultimate solution for this may be to remove the
editor.newandeditor.editroutes in favor of just having aneditorroute. new/edit already share almost all of their code, and I feel like the separation between the two has caused a lot of issues as we try to refactor autosave ( #4321's attempted fixes, for example )