Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Client management screen #6325

Closed
wants to merge 42 commits into from
Closed

[WIP] Client management screen #6325

wants to merge 42 commits into from

Conversation

zinyando
Copy link
Contributor

This is a WIP pull request for #4177

TODO

  • List clients
  • List clients acceptance test
  • Edit client
  • Edit client acceptance test
  • Add new client
  • Add new client acceptance test
  • Enable/Disable client
  • Enable/Disable client acceptance test
  • Refresh secret
  • Refresh secret acceptance test
  • Form validation
  • Make special clients not editable
  • Adding and removing of multiple trusted domains

@@ -1 +1 @@
Subproject commit de91a4006b49868aa5ffc1f7af3b79abe1595897
Subproject commit 1c092c7be098bed496eaa2f194a3ae39dd23659d

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

@acburdine
Copy link
Member

Hey @zinyando, any update on this? 😄

@zinyando
Copy link
Contributor Author

@acburdine I am waiting on the API part to be finished so that I can finish up and test whether it all works. Any update on that?

@acburdine
Copy link
Member

Looks like progress is stalled on the clients API PR, I might be able to pick it up later this week if I have time.

@zinyando
Copy link
Contributor Author

Ok, let me rebase and fix the failing test and jshint while we wait for the API.

validationType: 'client',
slugGenerator: service(),

init() {

This comment was marked as abuse.

@kevinansfield
Copy link
Member

Hey @zinyando, thanks for all your work on this! We've recently split all of the client files out into a separate Ghost-Admin project - would you mind re-opening this PR over there? Thanks 😃

@zinyando
Copy link
Contributor Author

@kevinansfield Ok I'll move the PR, is there a design/css that I should update my code with?

@kirrg001 kirrg001 changed the title WIP: Client management screen [WIP] Client management screen Jan 4, 2017
@kirrg001
Copy link
Contributor

kirrg001 commented Jan 4, 2017

Closing this PR as it belongs into https://github.com/TryGhost/Ghost-Admin as @kevinansfield pointed out.

@zinyando If you need any help or if you have furhter questions please join our slack channel :) Thanks for your work!

@kirrg001 kirrg001 closed this Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants