-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Client management screen #6325
Conversation
@@ -1 +1 @@ | |||
Subproject commit de91a4006b49868aa5ffc1f7af3b79abe1595897 | |||
Subproject commit 1c092c7be098bed496eaa2f194a3ae39dd23659d |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Hey @zinyando, any update on this? 😄 |
@acburdine I am waiting on the API part to be finished so that I can finish up and test whether it all works. Any update on that? |
Looks like progress is stalled on the clients API PR, I might be able to pick it up later this week if I have time. |
Ok, let me rebase and fix the failing test and jshint while we wait for the API. |
validationType: 'client', | ||
slugGenerator: service(), | ||
|
||
init() { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This is necessary because when writing test that click on page, click event bubbles to body and triggers click event handler that's bound to the body.
Hey @zinyando, thanks for all your work on this! We've recently split all of the client files out into a separate Ghost-Admin project - would you mind re-opening this PR over there? Thanks 😃 |
@kevinansfield Ok I'll move the PR, is there a design/css that I should update my code with? |
Closing this PR as it belongs into https://github.com/TryGhost/Ghost-Admin as @kevinansfield pointed out. @zinyando If you need any help or if you have furhter questions please join our slack channel :) Thanks for your work! |
This is a WIP pull request for #4177
TODO