Avoid use of this.attrs for closure actions

[kevinansfield]

no issue

• this.attrs is a glimmer-component thing (which doesn't exist in Ghost yet), to avoid confusion we should avoid using it. A couple of references:
  • https://locks.svbtle.com/to-attrs-or-not-to-attrs
  • Should actions be invoked and checked as this.attrs.action cibernox/ember-power-select#233 (comment)

[novaugust]

Both of the links you provide are just saying to not use this.attrs for non-closure-action attributes, but that actions are okay.
But I guess the point of what you're getting at is

to avoid confusion and potential unexpected behaviour we should avoid using it

[kevinansfield]

@novaugust yeah, for sure this.attrs for closure actions will work fine but it's an exception specifically for closure actions.

I've seen the this.get('foo')() or get(this, 'foo')() style being used much more frequently in the ember community recently and we even have mentors advising contributors to avoid the this.attrs style as seen in #6325 (comment). If we're choosing one style and sticking with it I'd prefer to fall on the side of the community adopted approach 😄

[acburdine]

@kevinansfield Couple of minor bugs, fix those and this is 👍

[kevinansfield]

@acburdine Thanks, fixed the bug and added a regression test 😄