Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jekyll migration tool #365

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Add Jekyll migration tool #365

merged 1 commit into from
Nov 26, 2021

Conversation

PaulAdamDavis
Copy link
Member

No description provided.

@PaulAdamDavis PaulAdamDavis merged commit ae9315a into master Nov 26, 2021
@PaulAdamDavis PaulAdamDavis deleted the add-jekyll-tool branch November 26, 2021 21:07
@markstos
Copy link
Contributor

markstos commented Jun 2, 2022

@PaulAdamDavis Thanks for this. Could you clarify in the docs where the "supplied zip" comes from or the expected format? The jekyll command doesn't have a built-in zip export subcommand.

@markstos
Copy link
Contributor

markstos commented Jun 2, 2022

From reading the source code, there's a comment that the tool is only known to work on exports from Medium:

https://github.com/TryGhost/migrate/blob/main/packages/mg-jekyll-export/lib/read-zip.js#L11

@markstos
Copy link
Contributor

markstos commented Jun 2, 2022

It would helpful if the fields recognized from the front matter are documented.

From looking at the source here, it's clear that date, author and title are recognized.

It's not clear that tags from the frontmatter are carried over. Also, I don't see other frontmatter attributes being processed like permalink, basename and category.

@PaulAdamDavis
Copy link
Member Author

Hi @markstos! I've just pushed the ability to handle tag, tags, category, and categories front matter.

I've also added a brief explanation of the expected folder structure.

This tool was intended to handle a very vanilla Jekyll site, and at the time didn't need to consume permalink or basename values.

If you can see value in adding support for these, please do open a new issue :)
Pull requests are always welcome, and real-world test data we can build & test against is also very welcome!

@markstos
Copy link
Contributor

markstos commented Jun 5, 2022

@PaulAdamDavis Thanks for the quick reply and update. I've opened an issue to support permalink and basename and submitted a PR that will make the category the primary tag, which seems like a better choice than the first post tag.

#505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants