Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] Toggle Options #4

Closed
itsMarkiS opened this issue Jul 2, 2023 · 6 comments · Fixed by #7
Closed

[Request] Toggle Options #4

itsMarkiS opened this issue Jul 2, 2023 · 6 comments · Fixed by #7
Assignees
@Tschipcraft
Labels
feature request New feature or request

Comments

@itsMarkiS
Copy link

Is your suggested enhancement related to a problem? Please describe.

i really love the mod even if it is just some small details, but the thing is that sometimes i just dont want the bubbles to work with some features, like when im fishing

Describe the solution you'd like

adding a option to toggle on-off in config files

Describe alternatives you've considered

disabling it
or adding modmenu config

Additional context

No response
@itsMarkiS itsMarkiS added the enhancement Changes for an existing feature label Jul 2, 2023
@Tschipcraft
Copy link
Owner

I sadly can't detect how bubbles particles got spawned into the world, for example via fishing, so a setting like that would just disable overhauled bubble particles in general.
In what scenarios would you like to be able to disable the bubbles and is it just the overhauled motion, the popping itself or the sounds?

@Tschipcraft Tschipcraft added status: needs information Further information is requested feature request New feature or request and removed enhancement Changes for an existing feature labels Jul 3, 2023
@Answordy
Copy link

Ocean monuments are super laggy with the mod, would be nice if bubbles made by guardians would be ignored, but thats probably not possible, sadly.

@Tschipcraft
Copy link
Owner

No, the only option would be to completely disable bubbles spawned by guardians or to generally lower the bubble lifetime with a settings slider or smth

@Answordy
Copy link

Well, even those options are better than having 10-20 fps or turning off the mod/all bubble particles. But that is just my opinion.

@Tschipcraft
Copy link
Owner

Damn, I really didn't expect it being that bad for lower end machines...
Will be changed in the future

@ihnele
Copy link

ihnele commented Jan 13, 2024

This is also really bad when you're using a pearl stasis chamber with several pearls floating in soul sand.

@Tschipcraft Tschipcraft self-assigned this Jan 16, 2024
@Tschipcraft Tschipcraft removed the status: needs information Further information is requested label Feb 29, 2024
@Tschipcraft Tschipcraft linked a pull request Jul 7, 2024 that will close this issue
v0.3.0 #7
Merged
@Tschipcraft Tschipcraft mentioned this issue Jul 11, 2024
Merged
Tschipcraft added a commit that referenced this issue Jul 11, 2024
@Tschipcraft
Backport v0.3.0 (#7)
3c426c5 
- Added config file and settings menu when installed alongside MidnightLib (#4)
- Added entity interaction physics to bubbles
- Added biome dependent tint to all bubble types
- Fixed barrels opened by other players on servers not emitting bubbles (#11) (Thanks @AViewFromTheTop)
- Adjusted current down bubbles to pop on top of magma blocks rather than inside them (#9)
- Added varied pitch and volume to bubble pop and bubble swirl sounds (#8)
- Barrel bubbling is now reliable on the client and will no longer bubble when a chunk with an already opened Barrel is loaded (Thanks @AViewFromTheTop)
- Changed the default behavior to not maintain bubble particle velocity when popping (Thanks @AViewFromTheTop)
- Tweaked explosion bubbles and used better variable names
- Restructured bubble particle logic and used better variable types
- Adjusted barrel bubble spawn locations
- Moved bubble pop logic to a separate utility class to reduce code duplication
- Simplified water checks to use the already provided helper function in world or level
- Fixed literal new line in fabric.mod.json after building (#12)
- Updated to Gradle 8.7, Loom 1.6 and ForgeGradle 6.+
Tschipcraft added a commit that referenced this issue Jul 11, 2024
@Tschipcraft
Backport v0.3.0 (#7)
0c29d53 
- Added config file and settings menu when installed alongside MidnightLib (#4)
- Added entity interaction physics to bubbles
- Added biome dependent tint to all bubble types
- Fixed barrels opened by other players on servers not emitting bubbles (#11) (Thanks @AViewFromTheTop)
- Adjusted current down bubbles to pop on top of magma blocks rather than inside them (#9)
- Added varied pitch and volume to bubble pop and bubble swirl sounds (#8)
- Barrel bubbling is now reliable on the client and will no longer bubble when a chunk with an already opened Barrel is loaded (Thanks @AViewFromTheTop)
- Changed the default behavior to not maintain bubble particle velocity when popping (Thanks @AViewFromTheTop)
- Tweaked explosion bubbles and used better variable names
- Restructured bubble particle logic and used better variable types
- Adjusted barrel bubble spawn locations
- Moved bubble pop logic to a separate utility class to reduce code duplication
- Simplified water checks to use the already provided helper function in world or level
- Fixed literal new line in fabric.mod.json after building (#12)
- Updated to Gradle 8.7, Loom 1.6 and ForgeGradle 6.+
This was referenced Aug 3, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tschipcraft Tschipcraft

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.3.0 AViewFromTheTop/make_bubbles_pop
4 participants
@ihnele @itsMarkiS @Tschipcraft @Answordy