Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test errors with LogDensityProblemsAD >= 1.2 #1942

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

devmotion
Copy link
Member

Fixes test failures introduced by tpapp/LogDensityProblemsAD.jl#5.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
weihanglo Weihang Lo
Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this as soon as tests pass!

Btw, how does that PR cause issue?

@devmotion
Copy link
Member Author

The (IMO internal) structs were moved to the extensions submodules.

@torfjelde
Copy link
Member

Ah I see! Thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4044785449

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 3974319921: 0.0%
Covered Lines: 0
Relevant Lines: 1422

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (17c45e9) compared to base (117e8bc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1942   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          21      21           
  Lines        1422    1422           
======================================
  Misses       1422    1422           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devmotion devmotion merged commit 5b976dc into master Jan 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the dw/fix_tests branch January 30, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants