Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use weak dependencies if supported #5

Merged
merged 5 commits into from
Jan 29, 2023
Merged

Use weak dependencies if supported #5

merged 5 commits into from
Jan 29, 2023

Conversation

devmotion
Copy link
Collaborator

@devmotion devmotion commented Dec 26, 2022 •
edited
Loading

Fixes #2.

Edit: Shouldn't be merged until the Registrator deployment of JuliaRegistries/Registrator.jl#397 is done.

@devmotion devmotion marked this pull request as draft December 30, 2022 14:16
@devmotion devmotion marked this pull request as ready for review January 29, 2023 00:14
@devmotion devmotion requested a review from tpapp January 29, 2023 00:22
@devmotion
Copy link
Collaborator Author

It seems to work as expected: https://github.com/tpapp/LogDensityProblemsAD.jl/actions/runs/4034225855/jobs/6935256894#step:6:225

@devmotion devmotion merged commit 6b36a58 into master Jan 29, 2023
@devmotion devmotion deleted the dw/weakdeps branch January 29, 2023 20:37
@devmotion devmotion mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpapp tpapp tpapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use weak dependencies instead of requires
2 participants
@devmotion @tpapp