Skip to content

Commit

Permalink
🌹 move typescript as a dev dependency so people can update independently
Browse files Browse the repository at this point in the history
  • Loading branch information
@basarat
basarat authored Jul 7, 2016
1 parent 97eaeec commit baeb648
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@
"commondir": "^1.0.1",
"convert-source-map": "^1.1.0",
"through2": "^2.0.0",
"tsconfig": "^2.2.0",
"typescript": "~1.8.7"
"tsconfig": "^2.2.0"
},
"devDependencies": {
"babel-preset-react": "^6.5.0",
Expand All @@ -45,6 +44,7 @@
"source-map": "^0.5.3",
"tape": "^4.0.0",
"test-peer-range": "^1.0.1",
"typescript": "~1.8.7",
"watchify": "^3.2.1"
},
"peerDependencies": {
Expand Down

4 comments on commit baeb648

@cartant
Copy link
Contributor

@cartant cartant commented on baeb648 Aug 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basarat As well as being in devDependencies, shouldn't typescript be added to peerDependencies? It's a required dependency; it's not optional. If so, what should be the minimum sermver? 1.8?

@basarat
Copy link
Member Author

@basarat basarat commented on baeb648 Aug 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as being in devDependencies, shouldn't typescript be added to peerDependencie

good idea. I would go with * till something turns up as a problem.

@cartant
Copy link
Contributor

@cartant cartant commented on baeb648 Aug 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. However, there is a minimum, now, as I've used the rootDir option - in #174 - to simplify things. And I think it was only introduced in 1.5.

I guess I should have a look to see if the current release works with versions earlier than 1.5. If it does, I suppose #174 is a breaking change. I don't suppose you happen to know tsify's minimum required TypeScript version?

@basarat
Copy link
Member Author

@basarat basarat commented on baeb648 Aug 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't suppose you happen to know tsify's minimum required TypeScript version?

I'd be happy with 1.8.

Please sign in to comment.