Convert Unsupported Operations #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1557 BREAKING CHANGE: `actionsWhitelist` is renamed to `actionsSafelist` `actionsBlacklist` is renamed to `actionsBlocklist` BEFORE: ```ts StoreDevtoolsModule.instrument({ actionsWhitelist: ['...'], actionsBlacklist: ['...'] }) ``` AFTER: ```ts StoreDevtoolsModule.instrument({ actionsSafelist: ['...'], actionsBlocklist: ['...'] }) ```
Closes #1558 BREAKING CHANGE: Selectors with only a projector function aren't valid anymore. This change will make the usage more consistent. BEFORE: ``` const getTodosById = createSelector( (state: TodoAppSchema, id: number) => state.todos.find(p => p.id === id) ); ``` AFTER: ``` const getTodosById = createSelector( (state: TodoAppSchema) => state.todos, (todos: Todo[], id: number) => todos.find(p => p.id === id) ); ```
Closes #1662 BREAKING CHANGES: usage of forRoot is now required for StoreRouterConnectingModule BEFORE: ```ts @NgModule({ imports: [ StoreRouterConnectingModule ] }) export class AppModule {} ``` AFTER: ```ts @NgModule({ imports: [ StoreRouterConnectingModule.forRoot() ] }) export class AppModule {} ```
Closes #1657 BREAKING CHANGE: Internal functions and tokens are removed from the public API
Applitools has become flaky with no obvious changes. Will diagnose failures and re-enable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information