Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Windows drive #4

Closed
JoePue opened this issue Jan 27, 2017 · 4 comments
Closed

Change Windows drive #4

JoePue opened this issue Jan 27, 2017 · 4 comments

Comments

@JoePue
Copy link

JoePue commented Jan 27, 2017

If I have a file "E:\testdir\test.txt" and i want open a terminal on this drive in this folder, then your extension works not correctly, because your extension will not change the drive by enter "E:". Actually the executed command "cd E:\testdir" is not enough for windows.
Could you please extend your extension and support different windows drives.
Best regards
Joe

@JoePue
Copy link
Author

JoePue commented Feb 12, 2017

How can I help you? (I'am not really understood the 'help wanted' tag)

@Tyriar
Copy link
Owner

Tyriar commented Feb 13, 2017

I'm open to accepting a PR, you would need to add some special logic for Windows in https://github.com/Tyriar/vscode-terminal-here/blob/master/src/extension.ts to check if there is a drive letter.

saaketp added a commit to saaketp/vscode-terminal-here that referenced this issue Jan 3, 2018
Fixes Tyriar#4

Check for cmd.exe in config, similar to wsl bash check
and send 1st two characters of the path before doing cd to change drive letter.
saaketp added a commit to saaketp/vscode-terminal-here that referenced this issue Jan 3, 2018
Fixes Tyriar#4

Check for cmd.exe in config, similar to wsl bash check
and send 1st two characters of the path before doing cd to change drive letter.
@Tyriar Tyriar closed this as completed in #11 Jan 3, 2018
@noman9607
Copy link

Are you new? This is simple, just use the /d flag like this: "CD /D path-filename". We are talking dos 2 or 3, like the early eighties. Type cd /? in your console window and read all about it. There is no penalty for using the d flag when you do not need it. This is how I edit your command so that it will work.

@Tyriar
Copy link
Owner

Tyriar commented Dec 5, 2018

@noman9607 feel free to make a PR to improve it, lose the attitude though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants