Change drive letter before cd in case of cmd.exe #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Jan 3, 2018
src/extension.ts
Outdated
| dir = dir.replace(/(\w):/, '/mnt/$1').replace(/\\/g, '/') | ||
| break; | ||
| case "cmd": | ||
| terminal.sendText(dir.slice(0,2)); |
There was a problem hiding this comment.
A comment here explaining what it's doing would be good, also do you know if we need to do this for powershell?
There was a problem hiding this comment.
I amended the commit to add comments before the line.
This was not required for powershell, it handles different drive letters on its own.
Fixes Tyriar#4 Check for cmd.exe in config, similar to wsl bash check and send 1st two characters of the path before doing cd to change drive letter.
|
Thanks @saaketp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
This checks if the windows shell is cmd.exe similar to wsl bash check in pull request #10.
I modified the "isWslBash" function and made a "kindOfShell" that returns string "wslbash" or "cmd".
This was to avoid creating a new function isCmd and duplicating most of the code from isWslBash.
So now instead of an if condition we have a switch case.
In cmd.exe cd works only for paths within the current drive letter (which is C: usually when cmd is started).
To change the drive letter we need to send the drive letter and a colon to the terminal.
Screen cap: