Support Windows Subsystem for Linux #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Dec 31, 2017
src/extension.ts
Outdated
|
|
||
| const lowerCase = windowsShellPath.toLowerCase(); | ||
|
|
||
| return (lowerCase.indexOf('system32') !== -1) && (lowerCase.indexOf('bash') !== -1); |
There was a problem hiding this comment.
We could probably make this detection a little better by checking if Windows is running in WoW64 mode (more info) and also using %windir%, you can see how this is done in VS Code here:
There was a problem hiding this comment.
Agree. Seeing the reference, I feel that there's no common module that detects bash used in the target system. But in this case, I can implement the detection in the same way, and refer to the source code from src/extension.ts. Let me make another commit for it.
dyong0
force-pushed
the
fix/wsl-support
branch
from
4ef3ca4 to
eb9c7dc
Compare
Fixes Tyriar#5 Determine the bash path by checking Windows shell path in config.
dyong0
force-pushed
the
fix/wsl-support
branch
from
eb9c7dc to
80291e6
Compare
|
@Tyriar I fixed the issue according to your review, but amended the commit instead of making new one. Because the new commit wouldn't help others. And the test result is same as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
It determines the directory path by checking Windows shell path.
The shell paths are listed in the official VS Code page.
https://code.visualstudio.com/docs/editor/integrated-terminal
Please kindly consider this pull request to be merged, I really need this feature.
Screen captures of the actual usages: