Skip to content

Commit

Permalink
Use constant line-height
Browse files Browse the repository at this point in the history
Unicode characters have a constant height when using a decimal (eg. 1.2) but
can overlap which looks unattractive on some browsers that use transparent
selections (Chrome). "normal" line-height differs for CJK and other unicode
chars, only exactly pixel sized seems to work all the time.

Fixes xtermjs#149
  • Loading branch information
Tyriar committed Jul 16, 2016
1 parent 13644ce commit 1311a13
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/xterm.css
Original file line number Diff line number Diff line change
Expand Up @@ -2141,9 +2141,9 @@
}

/**
* All terminal rows should have explicitly declared height,
* in order to allow child elements to adjust.
* All terminal rows should have explicitly declared height, in order to allow child elements to
* adjust. line-height:normal does not provide a fixed height for all unicode characters.
*/
.terminal .xterm-rows > div {
line-height: normal;
line-height: 18px;
}

0 comments on commit 1311a13

Please sign in to comment.