-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lines containing unicode characters differ in height #149
Comments
@Tyriar are you aware of any way we can fix this? Could we somehow (based on font-size I guess) know what is the appropriate line height to set, in order not to have lines with variant line heights? |
The way I'm probably going to approach a fit for vscode at least which allows a configurable |
Unicode characters have a constant height when using a decimal, but differ when using normal. Fixes xtermjs#149
Unicode characters have a constant height when using a decimal (eg. 1.2) but can overlap which looks unattractive on some browsers that use transparent selections (Chrome). "normal" line-height differs for CJK and other unicode chars, only exactly pixel sized seems to work all the time. Fixes xtermjs#149
Using the demo, lines with CJK characters at 24px, regular lines are 18px, and my prompt character is 20px.
This is the reason that on my computer the size of the terminal increases every time I press enter; because the
❯
character is being added, pushing out the height of the line.The text was updated successfully, but these errors were encountered: