Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines containing unicode characters differ in height #149

Closed
Tyriar opened this issue Jun 27, 2016 · 2 comments
Closed

Lines containing unicode characters differ in height #149

Tyriar opened this issue Jun 27, 2016 · 2 comments
Labels
type/bug Something is misbehaving

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2016

Using the demo, lines with CJK characters at 24px, regular lines are 18px, and my prompt character is 20px.

image

This is the reason that on my computer the size of the terminal increases every time I press enter; because the character is being added, pushing out the height of the line.

@parisk
Copy link
Contributor

parisk commented Jun 28, 2016

@Tyriar are you aware of any way we can fix this? Could we somehow (based on font-size I guess) know what is the appropriate line height to set, in order not to have lines with variant line heights?

@Tyriar
Copy link
Member Author

Tyriar commented Jun 28, 2016

The way I'm probably going to approach a fit for vscode at least which allows a configurable font-size and line-height, is to make the default line-height a fixed pixel size and set it as the height as well. Setting height and line-height forces all chars to be aligned the same and all lines to be the same height.

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 16, 2016
Unicode characters have a constant height when using a decimal, but differ
when using normal.

Fixes xtermjs#149
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 16, 2016
Unicode characters have a constant height when using a decimal (eg. 1.2) but
can overlap which looks unattractive on some browsers that use transparent
selections (Chrome). "normal" line-height differs for CJK and other unicode
chars, only exactly pixel sized seems to work all the time.

Fixes xtermjs#149
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 3, 2016
@Tyriar Tyriar mentioned this issue Aug 3, 2016
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

2 participants