Use constant line-height #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unicode characters have a constant height when using a decimal (eg. 1.2) but can overlap which looks unattractive on some browsers that use transparent selections (Chrome). "normal" line-height differs for CJK and other unicode chars, only exactly pixel sized seems to work all the time. Fixes xtermjs#149
|
Hmmm, not sure if hardcoding font-size to px is the right way to go here. What about setting both font size and line height to 1em? Changing this also means that we should document how different font sizes should work on xterm.js (demanding updating of both font size and line height). |
|
I believe 1em translates directly to 16px, 18px just seemed to work for default font size. You can see how I handled this case in vscode here https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/terminal/electron-browser/terminalPanel.ts#L292 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unicode characters have a constant height when using a decimal (eg. 1.2) but
can overlap which looks unattractive on some browsers that use transparent
selections (Chrome). "normal" line-height differs for CJK and other unicode
chars, only exactly pixel sized seems to work all the time.
Fixes #149