This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Updated readme & Added new .msg for CAN transceiver / Simulation Interface #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added sim_cmd, boat_cmd - Updated readme for above and CAN transceiver
hhenry01
approved these changes
Nov 18, 2023
|
Do you think it is worth it to add markdown comments for formatting e.g: Within the markdown for future convenience? |
Sure, good idea |
patrick-5546
approved these changes
Nov 18, 2023
There was a problem hiding this comment.
LGTM after these small changes. @hhenry01 should we update placeholders at this stage based off your discussion with @DFriend01?
DFriend01
reviewed
Nov 18, 2023
colinli02
force-pushed
the
user/colinli02/update_readme_and_can_transceiver
branch
from
b97c005
to
37da6d1
Compare
DFriend01
reviewed
Nov 20, 2023
DFriend01
approved these changes
Nov 24, 2023
DFriend01
added
enhancement
colinli02
deleted the
user/colinli02/update_readme_and_can_transceiver
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verification