Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Add UML Diagram for External Intfs #29

Merged
merged 4 commits into from
Dec 10, 2023
Merged

Conversation

hhenry01
Copy link
Member

@hhenry01 hhenry01 commented Nov 21, 2023

Description

Verification

  • Renders as:
    image

Resources

@hhenry01 hhenry01 added the documentation Improvements or additions to documentation label Nov 21, 2023
@hhenry01
Copy link
Member Author

hhenry01 commented Dec 4, 2023

There's currently some confusion over the status of the global_path topic using a msg or a service, so I'm waiting on that to resolve before continuing.

@hhenry01 hhenry01 force-pushed the user/hhenry01/22-UML-Diagrams branch 2 times, most recently from 3c80177 to 4bea1e5 Compare December 9, 2023 07:09
@hhenry01 hhenry01 marked this pull request as ready for review December 9, 2023 07:10
@hhenry01 hhenry01 requested a review from a team as a code owner December 9, 2023 07:10
@hhenry01
Copy link
Member Author

hhenry01 commented Dec 9, 2023

I'm guessing the other interface tables are simple enough to understand without a diagram. Alternatively we could make one of the members do the other diagrams.

Copy link
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will also want to verify that this renders correctly on docs site once merged in

@hhenry01 hhenry01 merged commit cb58efb into main Dec 10, 2023
12 checks passed
@hhenry01 hhenry01 deleted the user/hhenry01/22-UML-Diagrams branch December 10, 2023 04:49
@hhenry01
Copy link
Member Author

It does not render on the docs site.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace external interfaces table with UML diagram
2 participants