Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Sail Class With Tests #327

Merged
merged 15 commits into from
Mar 29, 2024
Merged

Implemented Sail Class With Tests #327

merged 15 commits into from
Mar 29, 2024

Conversation

evannawfal
Copy link
Contributor

Description

Verification

  • Test suite in sailbot_workspace/src/controller/tests/unit/wingsail/test_controllers.py

Resources

  • uses LUT (look up table) class

@alberto-escobar
Copy link
Contributor

alberto-escobar commented Mar 16, 2024 •
edited
Loading

Additional information

Description

Verification

  • Tested that output is writing messages by running ros node

Resources

  • uses LUT and WingsailController classes

This was referenced Mar 16, 2024
Closed
Closed
@alberto-escobar
Copy link
Contributor

github actions : "All checks have passed"
me: https://www.youtube.com/watch?v=KN3IemyqJJw

patrick-5546
patrick-5546 reviewed Mar 17, 2024
View reviewed changes
Copy link
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the old infra files and binaries:

  • .vscode/settings.json
  • compile_commands.json
  • virtual_iridium/python/*.pyc

@alberto-escobar
Copy link
Contributor

Please remove the old infra files and binaries:

  • .vscode/settings.json
  • compile_commands.json
  • virtual_iridium/python/*.pyc

This is done now, pushed changes with files removed

@alberto-escobar alberto-escobar linked an issue Mar 18, 2024 that may be closed by this pull request
Wingsail controller integration #302
Closed
@patrick-5546 patrick-5546 added the ctrl Controller team label Mar 19, 2024
DFriend01
DFriend01 requested changes Mar 22, 2024
View reviewed changes
src/controller/controller/wingsail/controllers.py Outdated Show resolved Hide resolved
src/controller/controller/wingsail/controllers.py Outdated Show resolved Hide resolved
src/controller/controller/wingsail/controllers.py Outdated Show resolved Hide resolved
@evannawfal evannawfal requested a review from jahn18 as a code owner March 23, 2024 17:31
@DFriend01 DFriend01 merged commit f489e85 into main Mar 29, 2024
11 of 12 checks passed
@DFriend01 DFriend01 deleted the evannawfal/303-sail-controller branch March 29, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alberto-escobar alberto-escobar alberto-escobar left review comments

@patrick-5546 patrick-5546 patrick-5546 left review comments

@jahn18 jahn18 jahn18 approved these changes

@DFriend01 DFriend01 DFriend01 approved these changes

Assignees
No one assigned
Labels
ctrl Controller team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sail Controller Class Wingsail controller integration
5 participants
@evannawfal @alberto-escobar @jahn18 @patrick-5546 @DFriend01