Implement Fluid Generation #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into arynrosh/304-fluid-simulation
eomielan
requested changes
Mar 22, 2024
src/boat_simulator/boat_simulator/nodes/physics_engine/fluid_generation.py
Outdated
Show resolved
Hide resolved
src/boat_simulator/boat_simulator/nodes/physics_engine/fluid_generation.py
Outdated
Show resolved
Hide resolved
src/boat_simulator/tests/unit/nodes/physics_engine/test_fluids.py
Outdated
Show resolved
Hide resolved
This reverts commit 6204043.
eomielan
approved these changes
Jun 1, 2024
samdai01
pushed a commit
that referenced
this pull request
Jun 15, 2024
* Migrate code for issue 304 * test 1 * test 2 * Fix linter errors, remove TODOs, add test for next() * Revert "test 2" This reverts commit 6204043. --------- Co-authored-by: Devon Friend <devon.fri.2000@gmail.com> Co-authored-by: Eric Omielan <112828024+eomielan@users.noreply.github.com> Co-authored-by: eomielan <eomielan@gmail.com> Co-authored-by: Patrick Creighton <pcreighton429@gmail.com>
samdai01
added a commit
that referenced
this pull request
Jul 13, 2024
* test * minor changes * added more comments for clarifications * Minor additions and corrections * Update custom_interfaces * working through AIS parsing * finished impelementing AIS parsing * AIS parsing works according to tests, modified custom interfaces HelperAISShip by changing its id from int32 to uint32 * modified HelperAISShips * cleaning up comments * Implemented rounding * Revert changes to website package-lock.json * Completed * Cleaning up some comments * Fixed publishing boat sim inputs * Modified battery frame and changed canid as needed for remaining frames. Unsure what what to do about sail cmd frames. * cleaned up old can frames, ready for new ones * Revert "cleaned up old can frames, ready for new ones" This reverts commit ddf0a9f. * Revert "Modified battery frame and changed canid as needed for remaining frames. Unsure what what to do about sail cmd frames." This reverts commit d4e2a4f. * Implement Fluid Generation (#328) * Migrate code for issue 304 * test 1 * test 2 * Fix linter errors, remove TODOs, add test for next() * Revert "test 2" This reverts commit 6204043. --------- Co-authored-by: Devon Friend <devon.fri.2000@gmail.com> Co-authored-by: Eric Omielan <112828024+eomielan@users.noreply.github.com> Co-authored-by: eomielan <eomielan@gmail.com> Co-authored-by: Patrick Creighton <pcreighton429@gmail.com> * Fixed DB Polling Lag (#395) * Fixed DB Polling Lag * No need for filter * Fix warning from test_controllers unit test (#397) * Refactor BoatState class for integration (#312) * Migrate PR 74 for boat_simulator * Add arguments for rudder angle and trim tab angle --------- Co-authored-by: Patrick Creighton <pcreighton429@gmail.com> Co-authored-by: Eric Omielan <112828024+eomielan@users.noreply.github.com> * Add instance variables to physics node (#403) * attempt to remove website changes * Revert "attempt to remove website changes" This reverts commit 396ad11. * Update raw_width in can_frame_parser.cpp * Updated more raw_width to uint16 in can_frame_parser.cpp --------- Co-authored-by: hhenry01 <henryhuang2001@gmail.com> Co-authored-by: Patrick Creighton <pcreighton429@gmail.com> Co-authored-by: Aryan Roshan <arynrosh@gmail.com> Co-authored-by: Devon Friend <devon.fri.2000@gmail.com> Co-authored-by: Eric Omielan <112828024+eomielan@users.noreply.github.com> Co-authored-by: eomielan <eomielan@gmail.com> Co-authored-by: Jordan Chen <122140935+JordanChen123@users.noreply.github.com> Co-authored-by: Devon Friend <69879126+DFriend01@users.noreply.github.com> Co-authored-by: Sam Dai <daisam1215@gmail.com> Co-authored-by: Sam Dai <89489298+samdai01@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verification