Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build dev image wokflow #77

Merged
merged 9 commits into from
Jan 19, 2023

Conversation

patrick-5546
Copy link
Member

Renamed dev container dockerfile name but did not update build dev image workflow accordingly

@patrick-5546
Copy link
Member Author

patrick-5546 commented Jan 14, 2023

Problems with rebuilding images

Dev

Rebuilt successfully, but getting this error when running ament_pep257:

Executing task in folder sailbot_workspace: ament_pep257 undefined src/ 

Traceback (most recent call last):
  File "/opt/ros/humble/bin/ament_pep257", line 33, in <module>
    sys.exit(load_entry_point('ament-pep257==0.12.4', 'console_scripts', 'ament_pep257')())
  File "/opt/ros/humble/lib/python3.10/site-packages/ament_pep257/main.py", line 125, in main
    report = generate_pep257_report(args.paths, excludes, args.ignore, args.select,
  File "/opt/ros/humble/lib/python3.10/site-packages/ament_pep257/main.py", line 190, in generate_pep257_report
    for filename, checked_codes, ignore_decorators in files_to_check:
ValueError: too many values to unpack (expected 3)

There is an extra element in each element of `` compared to the previous dev image. Perhaps rebuilding the base image would resolve this issue?

Base

Getting this error when building OMPL:

#17 452.9 [412/606] Building CXX object py-bindings/CMakeFiles/py_ompl_control.dir/bindings/control/vectorControlPtr.pypp.cpp.o
#17 452.9 In file included from /usr/include/boost/smart_ptr/detail/sp_thread_sleep.hpp:22,
#17 452.9                  from /usr/include/boost/smart_ptr/detail/yield_k.hpp:23,
#17 452.9                  from /usr/include/boost/smart_ptr/detail/spinlock_gcc_atomic.hpp:14,
#17 452.9                  from /usr/include/boost/smart_ptr/detail/spinlock.hpp:42,
#17 452.9                  from /usr/include/boost/smart_ptr/detail/spinlock_pool.hpp:25,
#17 452.9                  from /usr/include/boost/smart_ptr/shared_ptr.hpp:29,
#17 452.9                  from /usr/include/boost/shared_ptr.hpp:17,
#17 452.9                  from /usr/include/boost/python/converter/shared_ptr_to_python.hpp:12,
#17 452.9                  from /usr/include/boost/python/converter/arg_to_python.hpp:15,
#17 452.9                  from /usr/include/boost/python/call.hpp:15,
#17 452.9                  from /usr/include/boost/python/object_core.hpp:14,
#17 452.9                  from /usr/include/boost/python/args.hpp:22,
#17 452.9                  from /usr/include/boost/python.hpp:11,
#17 452.9                  from /build/py-bindings/bindings/control/vectorControlPtr.pypp.cpp:3:
#17 452.9 /usr/include/boost/bind.hpp:36:1: note: ‘#pragma message: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior.’
#17 452.9    36 | BOOST_PRAGMA_MESSAGE(
#17 452.9       | ^~~~~~~~~~~~~~~~~~~~
#17 452.9 /usr/include/boost/detail/iterator.hpp:13:1: note: ‘#pragma message: This header is deprecated. Use <iterator> instead.’
#17 452.9    13 | BOOST_HEADER_DEPRECATED("<iterator>")
#17 452.9       | ^~~~~~~~~~~~~~~~~~~~~~~
#17 452.9 [413/606] Building CXX object py-bindings/CMakeFiles/py_ompl_geometric.dir/bindings/geometric/AITstar.pypp.cpp.o
#17 452.9 In file included from /usr/include/boost/smart_ptr/detail/sp_thread_sleep.hpp:22,
#17 452.9                  from /usr/include/boost/smart_ptr/detail/yield_k.hpp:23,
#17 452.9                  from /usr/include/boost/smart_ptr/detail/spinlock_gcc_atomic.hpp:14,
#17 452.9                  from /usr/include/boost/smart_ptr/detail/spinlock.hpp:42,
#17 452.9                  from /usr/include/boost/smart_ptr/detail/spinlock_pool.hpp:25,
#17 452.9                  from /usr/include/boost/smart_ptr/shared_ptr.hpp:29,
#17 452.9                  from /usr/include/boost/shared_ptr.hpp:17,
#17 452.9                  from /usr/include/boost/python/converter/shared_ptr_to_python.hpp:12,
#17 452.9                  from /usr/include/boost/python/converter/arg_to_python.hpp:15,
#17 452.9                  from /usr/include/boost/python/call.hpp:15,
#17 452.9                  from /usr/include/boost/python/object_core.hpp:14,
#17 452.9                  from /usr/include/boost/python/args.hpp:22,
#17 452.9                  from /usr/include/boost/python.hpp:11,
#17 452.9                  from /build/py-bindings/bindings/geometric/AITstar.pypp.cpp:3:
#17 452.9 /usr/include/boost/bind.hpp:36:1: note: ‘#pragma message: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior.’
#17 452.9    36 | BOOST_PRAGMA_MESSAGE(
#17 452.9       | ^~~~~~~~~~~~~~~~~~~~
#17 452.9 /usr/include/boost/detail/iterator.hpp:13:1: note: ‘#pragma message: This header is deprecated. Use <iterator> instead.’
#17 452.9    13 | BOOST_HEADER_DEPRECATED("<iterator>")
#17 452.9       | ^~~~~~~~~~~~~~~~~~~~~~~
#17 452.9 ninja: build stopped: subcommand failed.
------
executor failed running [/bin/sh -c cmake         -DPYTHON_EXEC=/usr/bin/python3         -DOMPL_REGISTRATION=OFF         -DCMAKE_INSTALL_PREFIX=/usr         -G Ninja         /ompl &&     ninja update_bindings -j `nproc` &&     ninja -j `nproc` &&     ninja install]: exit code: 1

Could this be related to not using a C++17 compiler?

@patrick-5546
Copy link
Member Author

patrick-5546 commented Jan 19, 2023

Base image error was because I ran out of memory. Docker on Windows is just not as good as native linux, even having 32 GB was barely enough I had to close all other applications.

@patrick-5546
Copy link
Member Author

Temporarily removing the broken linter ament_pep257 and created an issue to add it back once its fixed

@patrick-5546 patrick-5546 disabled auto-merge January 19, 2023 21:47
@patrick-5546 patrick-5546 merged commit 1e20422 into main Jan 19, 2023
@patrick-5546 patrick-5546 deleted the user/patrick-5546/fix-build-dev-image-ci branch January 19, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants