Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C++ unit testing #58

Merged
merged 2 commits into from
Sep 2, 2023
Merged

Conversation

hhenry01
Copy link
Member

@hhenry01 hhenry01 commented Nov 14, 2022

Description

I added some extra unit testing tools in this PR.
image
Right clicking the green check also gives a context menu to run and debug individual tests which is nice.

Verification

@hhenry01 hhenry01 self-assigned this Nov 14, 2022
@hhenry01 hhenry01 linked an issue Nov 14, 2022 that may be closed by this pull request
3 tasks
@DFriend01 DFriend01 removed a link to an issue Nov 20, 2022
3 tasks
@DFriend01 DFriend01 linked an issue Nov 20, 2022 that may be closed by this pull request
3 tasks
Copy link
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this on hold until I upgrade the docker image to the latest Ubuntu and ROS LTS distributions. Perhaps this will resolve the missing file issue you discovered.

@patrick-5546 patrick-5546 marked this pull request as draft January 13, 2023 21:26
@patrick-5546
Copy link
Member

Copy link
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading over your PR I saw you tried to debug the ROS launch launch config. It should work in main now with ROS humble, but lmk if that isn't the case.

The unit testing tools look great. There is something similar that I configured for Python, so it's great that we can achieve feature parity.

lmk if you need help merging with main. You may find it easier to add your changes to a new branch rather than trying to resolve the merge conflicts.

@hhenry01 hhenry01 force-pushed the hhenry01/6-improve-debugging-experience branch 4 times, most recently from b7cc1ff to cd4ca8e Compare September 1, 2023 03:14
@hhenry01 hhenry01 marked this pull request as ready for review September 1, 2023 03:15
@hhenry01 hhenry01 force-pushed the hhenry01/6-improve-debugging-experience branch from cd4ca8e to fc44986 Compare September 1, 2023 03:16
@hhenry01
Copy link
Member Author

hhenry01 commented Sep 1, 2023

I rebased this branch and it's just for the unit testing extension now.

@patrick-5546 patrick-5546 changed the title Add ROS Node attach and CPP unit test extension Add C++ unit testing Sep 1, 2023
@patrick-5546 patrick-5546 added ctrl Controller team and removed sim Boat Simulator team labels Sep 1, 2023
Copy link
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that it works on my machine, if there's nothing else that you want to do in this PR feel free to merge

@hhenry01 hhenry01 merged commit ea90532 into main Sep 2, 2023
@hhenry01 hhenry01 deleted the hhenry01/6-improve-debugging-experience branch September 2, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ctrl Controller team infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve debugging experience
2 participants