-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C++ unit testing #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put this on hold until I upgrade the docker image to the latest Ubuntu and ROS LTS distributions. Perhaps this will resolve the missing file issue you discovered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading over your PR I saw you tried to debug the ROS launch launch config. It should work in main now with ROS humble, but lmk if that isn't the case.
The unit testing tools look great. There is something similar that I configured for Python, so it's great that we can achieve feature parity.
lmk if you need help merging with main. You may find it easier to add your changes to a new branch rather than trying to resolve the merge conflicts.
b7cc1ff
to
cd4ca8e
Compare
cd4ca8e
to
fc44986
Compare
I rebased this branch and it's just for the unit testing extension now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that it works on my machine, if there's nothing else that you want to do in this PR feel free to merge
Description
I added some extra unit testing tools in this PR.

Right clicking the green check also gives a context menu to run and debug individual tests which is nice.
Verification