Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to Pandas v2.0 #1112

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Conversation

matt-graham
Copy link
Collaborator

@matt-graham matt-graham commented Sep 18, 2023

Stop-gap solution as part of #763 which just updates existing pip based requirement files rather than also switching to fully conda based approach as in #949.

Given Pandas v2.1 has now been released assuming it is probably worth updating to use this assuming there aren't any major additional breaking changes over switch to v2.0 (which it doesn't look like there is from release notes).

Edit: Pandas v2.1 only support Python 3.9+ so rolling back pin to Panda v2.0 to maintain Python 3.8 compatibility for now.

From running tests locally it looks like at least some tests fail due to changes which are not Panda v2.0 compatible since I last worked on this, so will need to find and fix all of these first so marking this as draft for now.

@matt-graham matt-graham changed the title Update dependencies to Pandas v2.1 Update dependencies to Pandas v2.0 Sep 18, 2023
@matt-graham
Copy link
Collaborator Author

All the failures seem to be due to #1113 which is fixed by #1114 so 🤞 tests here will pass once that is merged in.

@matt-graham matt-graham force-pushed the mmg/update-dependencies-pip branch 2 times, most recently from efa9133 to fc43ba8 Compare September 28, 2023 08:49
@matt-graham
Copy link
Collaborator Author

After merging #1114 now just one single test failing which is that described in #1127 which should hopefully be fixed when #1142 is merged.

@matt-graham matt-graham force-pushed the mmg/update-dependencies-pip branch from fc43ba8 to 829e6cf Compare September 28, 2023 14:39
@matt-graham matt-graham marked this pull request as ready for review September 28, 2023 16:32
@matt-graham matt-graham requested a review from tamuri September 28, 2023 16:32
@matt-graham
Copy link
Collaborator Author

Tests now all passing with #1142 merged 🎉

Copy link
Collaborator

@tamuri tamuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, sterling effort!

@matt-graham matt-graham merged commit a9b2776 into master Sep 28, 2023
55 checks passed
@matt-graham matt-graham deleted the mmg/update-dependencies-pip branch September 28, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants