Roll back PR #1027 #1140
Merged
Roll back PR #1027 #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bbf33e2 **** & subsequent changes
|
@marghe-molaro -- are we happy with this one going in now? |
@joehcollins, I think you are better suited to double checking this, as it was your PR that's being rolled back. I can confirm that the combination of this PR with #1143 appears to solve issue #1102 as we were hoping. |
|
@marghe-molaro @tbhallett yep this looks correct to me! |
|
Thanks both. In that case, Please can you Approve this PR. |
marghe-molaro
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.