-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figures for Bingling's paper on Healthcare Workforce #436
base: master
Are you sure you want to change the base?
Conversation
Thanks for this @tbhallett. I am planning to first draw the HSI figure that is needed by the current draft, then move files that produce histograms and sankey diagrams to the folder you recommend. A quick question: how do I work on the branch "hallett/figure-to-describe-hsi" that you created for producing the figures? I tried to merge it to my local master but it does not show? |
Sounds perfect.
Check out this branch locally. Then you can work on it and push commits onto this branch, |
Thanks. Check out is working! |
I should also have said.... with this I am also aiming to introduce you to using our remote compute resource (Azure). We can discuss tomorrow in detail but hopefully you'll get the gist. Have you installed the things needed for using that yet? |
Sorry that I have no idea about the things needed to use Azure. Thanks for this arrangement. Looking forward to discussing with you tomorrow. Any time slot would be fine for me. |
Sorry @tbhallett, another quick question: for the generated figures, we aim to put them in the TLOmodel/outputs folder? And since there a quite a few figures for different measures and scenarios, do you mind if I create folders inside 'outputs' to store them separately? |
Note the latest failing tests should relate to commit cffd1ea, which reverted the merge of level 1b and 2 in master. Will leave these issues for now, as no need to re-submit scale run to update current results in HCW paper. |
# Conflicts: # src/scripts/calibration_analyses/analysis_scripts/analysis_compare_appt_usage_real_and_simulation.py
Hi Tim @tbhallett, I have updated the appt-hsi sankey for our HCW paper as below: old - subsets of appts and HSIs, no facility levels, based on very old scale run results (perhaps in the first submission) new - all appts and HSIs that are run, facility levels included, based on latest scale run Although the new is quite long, but I think it includes all the appts, facility levels and HSIs in TLO and provides a full picture of how each HSI is assigned to one or more appts, at one or more facility levels, thus providing a good illustration of HSIs and the linking to appts that using HCW capabilities at different levels. I wonder how you think of it? Is there any concern or comment? Many thanks. |
And thanks so much for the quick check and merging of PR #1072. I have merged in latest master. Will submit another scale run once all tests passed. Would be happy to update our HCW paper results subsequently, if the hsi calibration is improved as expected. |
WOW -- I think the new large one is beautiful ..... but that, unfortunately, people are not going to be able to read it and interpret it. However, I agree that that it's good to have one that shows all the HSI. Maybe taking out the 'stage' of facility level would make it more manageable!? Otherwise, I think it'd be OK to stick with the original smaller one, as it provides the "example" of the point we wish to make. |
The new plot (0) based on latest scale run as below. I am confident to use this one now, as it uses the latest results and it is clear to illustrate that the all relevant HSI events (that have appointment footprints on the left at level 1a) are using and competing for HCW capabilities through the currency of appointment types; also, the flow thickness reflects the relative proportions of HSI counts per appointment. (The one that covers all HSIs in TLO is very long and unclear for understanding; thus, we might not use it. However, I think it is fine as in our m/s we have referred to our tlo-HSI website for all HSI details: https://www.tlomodel.org/hsi_events.html) |
Thanks @BinglingICL. I'm very happy with that. I do like the long one and I'll put it on the website, as you suggest. |
…tes and better match with latest Model usage
Hi Tim, as I am updating the results, I noticed that PR #1027 has changed our hsi calibration results on MentalAll model/data ratio: now reduced to 0.4 as attached. The quick fix is in commit 32d317d, which could improve the ratio to 0.9 as below. I am using this fixed results (not much difference overall though) in the paper. Would be happy to raise a small PR to make the above commit to update the server tlo output, after I finished the current editing of the paper, if you think it would be helpful. |
Thanks. Yes, please do raise a PR for that change then |
@BinglingICL, we can use this PR to bring in the scripts being used to make the figures in your manuscript.
I would recommend placing them in
src/scripts/healthsystem/descriptions_of_input_data
and have them run off the files inresources
.I've also created some files in a folder called
src/scripts/healthsystem/hsi_in_typical_run
, which we can use to runthe model and analyse the HSI that are actually occuring. The file
scenario_hsi_in_typical_run.py
defines the model run and the fileanalysis_hsi_in_typical_run.py
extracts the data from that run and produces some simple descriptions of it. I think you will be able to do a very nice job of describing these results for the paper.