Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OHRI-2051 update metadata to use config in covid esm #1735

Merged
merged 6 commits into from
Jan 11, 2024
Merged

OHRI-2051 update metadata to use config in covid esm #1735

merged 6 commits into from
Jan 11, 2024

Conversation

ODORA0
Copy link
Contributor

@ODORA0 ODORA0 commented Jan 9, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

@ODORA0 ODORA0 marked this pull request as draft January 9, 2024 06:00
@ODORA0 ODORA0 marked this pull request as ready for review January 10, 2024 04:51
@ODORA0 ODORA0 requested a review from kajambiya January 10, 2024 05:05
kajambiya
kajambiya suggested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@kajambiya kajambiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ODORA0 This looks good but like @ebambo had inquired, let's add the form names to the config schema.

@kajambiya kajambiya merged commit 419162c into UCSF-IGHS:dev Jan 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kajambiya kajambiya kajambiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ODORA0 @kajambiya