chore(ui5-fcl): add template hooks for toggle arrows #2242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add template hooks for the toggle arrows of thew FlexibleColumnLayout, so that a derived class can fully customize them. For example: provide different or new ARIA attribbutes or change the values of existing ones. Note: We considered providing slots or proeprties, but we wanted to keep the API more simple and aggreed on this solution. FIXES: #2183
vladitasev
approved these changes
Sep 24, 2020
ilhan007
added a commit
that referenced
this pull request
Sep 24, 2020
Add template hooks for the toggle arrows of thew FlexibleColumnLayout, so that a derived class can fully customize them. For example: provide different or new ARIA attribbutes or change the values of existing ones. Note: We considered providing slots or proeprties, but we wanted to keep the API more simple and aggreed on this solution. FIXES: #2183
ilhan007
added a commit
that referenced
this pull request
Oct 17, 2020
Add template hooks for the toggle arrows of thew FlexibleColumnLayout, so that a derived class can fully customize them. For example: provide different or new ARIA attribbutes or change the values of existing ones. Note: We considered providing slots or proeprties, but we wanted to keep the API more simple and aggreed on this solution. FIXES: #2183
ilhan007
added a commit
that referenced
this pull request
Nov 11, 2020
Add template hooks for the toggle arrows of thew FlexibleColumnLayout, so that a derived class can fully customize them. For example: provide different or new ARIA attribbutes or change the values of existing ones. Note: We considered providing slots or proeprties, but we wanted to keep the API more simple and aggreed on this solution. FIXES: #2183
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add template hooks for the toggle arrows of thew Flexible Column Layout, so that a derived class can fully customize them.
For example: provide different or new ARIA attributes, change the values of existing ones, etc.
In order to that, the derived class should include the FCL template and overwrite the newly added "startArrow" and "endArrow" template hooks.
Note: We considered providing slots or properties, but we wanted to keep the API more simple and agreed on this solution.
FIXES: #2183