feat(ui5-menu): provide busy indicator display #6866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New property "busyIndicator" has been introduced. Through this property the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New property "busyIndicator" has been introduced. Through this property the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
ilhan007
previously requested changes
Apr 4, 2023
Contributor
ilhan007
left a comment
ilhan007
left a comment
There was a problem hiding this comment.
Clicking on "Request changes" just to be sure the core team have some time to do API review of this feature, @tsanislavgatev @NHristov-sap please continue with the review normally
New property "busyIndicator" has been introduced. Through this property the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New property "busyIndicator" has been introduced. Through this property the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New property "busyIndicator" has been introduced. Through this property the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New property "busyIndicator" has been introduced. Through this property the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New property "busyIndicator" has been introduced. Through this property the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New property "busyIndicator" has been introduced. Through this property the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New property "busyIndicator" has been introduced. Through this property the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New property "busyIndicator" has been introduced. Through this property the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
DavidMitreski5
approved these changes
Apr 5, 2023
Two new properties "busy" and "busyDelay" have been introduced. Through those properties the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
nnaydenow
previously requested changes
Apr 13, 2023
New properties "busy" and "busyDelay" have been introduced. Through those properties the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
DavidMitreski5
suggested changes
Apr 13, 2023
New properties "busy" and "busyDelay" have been introduced. Through those properties the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New properties "busy" and "busyDelay" have been introduced. Through those properties the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New properties "busy" and "busyDelay" have been introduced. Through those properties the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New properties "busy" and "busyDelay" have been introduced. Through those properties the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New properties "busy" and "busyDelay" have been introduced. Through those properties the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New properties "busy" and "busyDelay" have been introduced. Through those properties the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
DavidMitreski5
approved these changes
Apr 18, 2023
New properties "busy" and "busyDelay" have been introduced. Through those properties the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New properties "busy" and "busyDelay" have been introduced. Through those properties the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
New properties "busy" and "busyDelay" have been introduced. Through those properties the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: UI5#6131
NHristov-sap
approved these changes
Apr 18, 2023
1 task
1 task
NHristov-sap
pushed a commit
that referenced
this pull request
May 4, 2023
* feat(ui5-menu): provide busy indicator display New property "busyIndicator" has been introduced. Through this property the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: #6131
PetyaMarkovaBogdanova
pushed a commit
that referenced
this pull request
Jun 20, 2023
* feat(ui5-menu): provide busy indicator display New property "busyIndicator" has been introduced. Through this property the application developers will be able to configure a busy indicator display for a particular ui5-menu DOM representation. That way there will be a busy indicator while the corresponding menu item texts are getting fetched from a database. Fixes: #6131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New properties "busy" and "busyDelay" have been introduced.
Through those properties the application developers
will be able to configure a busy indicator display for a particular ui5-menu
DOM representation. That way there will be a busy indicator while
the corresponding menu item texts are getting fetched from a database.
Fixes: #6131