Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version #62

Merged
merged 49 commits into from
Jul 18, 2024
Merged

New version #62

merged 49 commits into from
Jul 18, 2024

Conversation

attiks
Copy link
Collaborator

@attiks attiks commented Jul 18, 2024

No description provided.

attiks and others added 30 commits June 27, 2024 15:13
[RW-996] Remove the user logged in requirements for the chat
[RW-1006] Submit question when pressing enter in the question textarea
Refs: RW-1017

Note that I haven't adjusted the positioning of the down arrow in the
dropdown element - this is handled by the browser, so would be breaking
consistency with other dropdowns.
[RW-1016] Reduce size of AI chat popup icon
chore: adjust padding for ai chat popup
[RW-1020] Allow setting the popup and chat page title via the UI
no_passage: 'Sorry, I could not find information to answer the question.'
no_answer: 'Sorry, I was unable to answer your question. Please try again in a short moment.'
invalid_answer: 'Sorry, I was unable to answer your question.'
document_embedding_error: 'Sorry, there was an error trying to retrieve the documents to the answer to your question.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be changed in the UI, so doesn't matter much, but could be phrased differently: "Sorry, there was an error trying to retrieve documents to answer your question."
In the next one, there's a typo ("qestion"), and the others could be rewritten to remove "I", and either remove 'in a short moment' or change it to 'shortly'.

Copy link
Contributor

@lazysoundsystem lazysoundsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already reviewed many of these changes - the others look right.

@attiks
Copy link
Collaborator Author

attiks commented Jul 18, 2024

Let's merge #63 first

attiks added 2 commits July 18, 2024 12:07
fix: ensure honeypot service is properly added to the chat form
Copy link

Monitor coverage for Drupal 10.3.x - PHP 8.3

Totals Coverage
Statements: 87.88% ( 116 / 132 )
Methods: 25% ( 2 / 8 )
Lines: 91.94% ( 114 / 124 )

Copy link

Monitor coverage for Drupal 10.2.x - PHP 8.3

Totals Coverage
Statements: 87.88% ( 116 / 132 )
Methods: 25% ( 2 / 8 )
Lines: 91.94% ( 114 / 124 )

Copy link

Monitor coverage for Drupal 10.2.x - PHP 8.2

Totals Coverage
Statements: 87.88% ( 116 / 132 )
Methods: 25% ( 2 / 8 )
Lines: 91.94% ( 114 / 124 )

Copy link

Monitor coverage for Drupal 10.3.x - PHP 8.2

Totals Coverage
Statements: 87.88% ( 116 / 132 )
Methods: 25% ( 2 / 8 )
Lines: 91.94% ( 114 / 124 )

@attiks attiks merged commit 688d00d into main Jul 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants