Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 0 translation in romanian 🇷🇴 #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alx-sima
Copy link

  • translated chapter 0 in romanian
  • translated common words in romanian
  • added links for the romanian page

Signed-off-by: Alexandru Sima <60713563+alx-sima@users.noreply.github.com>
Signed-off-by: Alexandru Sima <60713563+alx-sima@users.noreply.github.com>
Signed-off-by: Alexandru Sima <60713563+alx-sima@users.noreply.github.com>
lessons/ro/chapter_0.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_0.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_0.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_0.yaml Outdated Show resolved Hide resolved
lessons/ro/common_words.yaml Outdated Show resolved Hide resolved
Co-authored-by: Alexandru Radovici <msg4alex@gmail.com>
@alexandruradovici
Copy link

You can open the pull request to upstream. Please mention that this only adds the chapter 0 and that the rest in translation now. Post a link to the pull request in the pull request.

@alx-sima
Copy link
Author

alx-sima commented Jan 17, 2023

@alexandruradovici I've oppened a pull request on upstream.
richardanaya#454

@alexandruradovici alexandruradovici added the upstream This pull request was opened in the upstream repository label Jan 18, 2023
@alexandruradovici alexandruradovici changed the title Chapter 0 translation in romanian Chapter 0 translation in romanian 🇷🇴 Jan 27, 2023
@alexandruradovici
Copy link

I suggest adding the Romanian flag 🇷🇴 (copy paste) to the upstream pull request title.

Puteți naviga prin tur folosind tastele <span class="emoji">⬅️</span> și
<span class="emoji">➡️</span>.

În acest exemplu clasic arătăm că Rust suportă caractere Unicode.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cred ca e vorba despre codul de Rust din pagina (https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&code=fn%20main()%20%7B%0A%20%20%20%20println!(%22Salut%2C%20%F0%9F%A6%80%22)%3B%0A%7D%0A) care are un println!("Salut, 🦀");, care are un caracter unicode.

lessons/ro/chapter_0.yaml Outdated Show resolved Hide resolved
@alexandruradovici
Copy link

@alx-sima please make the suggested changes on this branch, copy it to a new branch (git branch) and submit a new pull request to upstream.

fixed typos (missing commas)

Co-authored-by: veraradovici <vera.radovici@gmail.com>
@alx-sima
Copy link
Author

alx-sima commented Feb 4, 2023

@alexandruradovici do I need to fork the upstream repo? Because I cannot automatically merge from this fork, even on a different branch.

@alexandruradovici
Copy link

No, just make a new branch out of this one and submit another pull request.

@alexandruradovici
Copy link

@alx-sima Please select a timeslot for the interview https://doodle.com/meeting/participate/id/eZ8gOOEb.

@alx-sima
Copy link
Author

alx-sima commented Feb 5, 2023

I've opened a pull request to upstream with the fix.

Also, what is the interview about?

@alexandruradovici
Copy link

alexandruradovici commented Feb 5, 2023

Also, what is the interview about?

The interview is for the NXP scholarship. We want to talk to you face to face.

@alx-sima
Copy link
Author

alx-sima commented Feb 5, 2023

Sounds good, but I have an exam that day and I don't know what would be the best time for the meeting.

@alexandruradovici
Copy link

alexandruradovici commented Feb 5, 2023

We can reschedule, please propose a day and a time.

shefancodeman added a commit to shefancodeman/Open-Source-Rust-2023 that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream This pull request was opened in the upstream repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants