Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Gemma 2 #223

Merged
merged 36 commits into from
Jan 10, 2025
Merged

Conversation

oreomaker
Copy link
Collaborator

Difference between Gemma and Gemma2

  • Gemma2 adds two feedforward layernorm before and after MLP
  • It changes the hidden_dim to 2304 while still using 2048 and 1024 for query dim and kv dim respectively.

@yirongjie yirongjie changed the title Support Gemma 2 featSupport Gemma 2 Jan 10, 2025
@yirongjie yirongjie changed the title featSupport Gemma 2 feat: Support Gemma 2 Jan 10, 2025
@yirongjie yirongjie merged commit 036bbbb into UbiquitousLearning:main Jan 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants