CURA-12091 Fix crash when started from AppImage #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harder, Better, Faster, Stronger
wawanbreton
changed the title
wawanbreton
changed the title
CURA-12091 C++ concepts are partially supported on XCode 13 (macOS 11) which we want to support. In this case, the defined concepts are not used for generic calls, so they can be safely removed.
CURA-12091 Now we use upload-artifact v4 instead of v3, we can't upload the same file twice
rburema
approved these changes
Sep 4, 2024
|
Thanks @HellAholic |
|
Completely forgot about the openssl. |
Well it could help, but not sure it will fix the Windows crash. Waiting for the runners to be online 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are just there to be able to build the plugin on our self-hosted runners.
The part that actually fixes the run issue is on the
conanfile.py, changing the binary interpreter e3933f7Note that I am not sure doing this change in the recipe is the best way. This may break execution when working with a locally installed Conan package. Maybe it should be in the curapackage creation workflow.
CURA-12091