CURA-12091 fix infill plugin start crash #19599
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting an engine plugin executable from within an AppImage, the AppImage hooks make some black magic to make sure the called executable is started from the OS environment. In our case this is not what we want, as the plugin is supposed to use the environment provided with the AppImage, which is compatible with more platforms.
This PR adds an environment variable before starting the engine plugin executable, to tell AppImage to consider the executable as if it was part of its environment.
This can also be achieved by starting cura with e.g.
APPDIR_MODULE_DIR=$HOME/.local/share/cura/5.8/plugins/CuraEngineTiledInfill/CuraEngineTiledInfill/x86_64/Linux ./UltiMaker-Cura-5.8.0-linux-X64.AppImage. Thus, one can use the Infil plugin version 2.0.1 with Cura 5.8.0 on platforms where it would not run (e.g. Mint 20). In 5.9.0 it will work out of the box.Requires Ultimaker/CuraEngine_plugin_infill_generate#19 (Or Infill plugin package 2.0.1)
May fix #17441
Fixes #17551
Fixes #17739
Fixes #18530
Should fix #19501 (changed build runner)
CURA-12091