Compatibility upgrade of scripts involving textures #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
Miepee
reviewed
Sep 3, 2024
| @@ -122,13 +122,14 @@ public static MagickImage ReadBGRAImageFromFile(string filePath) | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Performs a resize of the given image, if required, using bilinear interpolation. Always returns a new image. | |||
| /// Performs a resize of the given image, if required, using the specified interpolation (bilinear by default). Always returns a new image. | |||
There was a problem hiding this comment.
considering people usually make pixel games in GM, are we sure we don't want to use NN as the default instead?
There was a problem hiding this comment.
Not sure. I believe the old method used wasn't nearest-neighbor, and there could be a benefit of it being very obvious you just tried to upscale a sprite on accident. In NN it can be slightly less obvious, especially if the aspect ratio only slightly differs. This would mostly affect the GUI though, which probably uses the default parameters currently.
UndertaleModTool/Scripts/Technical Scripts/ImportGraphics_Full_Repack.csx
Outdated
Show resolved
Hide resolved
UndertaleModTool/Scripts/Technical Scripts/ImportGraphics_Full_Repack.csx
Outdated
Show resolved
Hide resolved
luizzeroxis
reviewed
Oct 3, 2024
Miepee
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #1870, upgrading existing built-in texture scripts to work with the changes made in that PR.
Some scripts had small syntax cleanup, as I went through them to make changes for textures.
A small amount of library and tool code was adjusted for the purpose of these script updates.
Caveats
Not every script was thoroughly tested (though a bunch were). Most scripts were at least tested to compile and start running. I may have also missed some scripts, but I did multiple searches through the code to figure out which scripts needed updating. This should still be better than nothing, however.
Multiple scripts still use Windows-only code, but the goal of this PR is only compatibility. Those scripts can get refactored in the future, and have been marked with TODO comments.
Notes
Followed all instances of
TextureWorkerandTextureBlobin scripts. Reviewed alongside the script changes made in #1538.