clean up freeing of libsrc4 metadata memory in HDF5 and HDF4 #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1433
Part of #1426
The current code to close a file needs a little cleanup for PIO use of the UDF feature.
In this PR I add function nc4_nc4f_list_del() to go with nc4_nc4f_list_add(). This new function cleans up the memory that was allocated by libsrc4 code. This allows some duplicate code to be removed from hdf4file.c and hdf5file.c, as well as making it easier for layers like PIO to use the libsrc4 metadata handling code.
This change is required for the netCDF/PIO integration. See NCAR/ParallelIO#1566.