Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simply version check logic #2015

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Simply version check logic #2015

merged 1 commit into from
Jun 28, 2021

Conversation

gsjaardema
Copy link
Contributor

We use the CMake VERSION_LESS test other places, might as well use it here and eliminate another compile-based test.

@gsjaardema
Simply version check logic
e755a08 
We use the CMake `VERSION_LESS` test other places, might as well use it here and  eliminate another compile-based test.
@gsjaardema gsjaardema requested a review from WardF as a code owner June 2, 2021 17:40
@WardF WardF merged commit e830313 into Unidata:master Jun 28, 2021
@gsjaardema gsjaardema deleted the patch-48 branch June 28, 2021 20:20
@dopplershift
Copy link
Member

@WardF This has broken the conda-forge build of 4.8.1 because it assumes ${HDF5_VERSION} is defined. The Win64 build on conda-forge goes through some path in the cmake build where that's not defined.

@dopplershift
Copy link
Member

dopplershift commented Aug 25, 2021 •
edited
Loading

See conda-forge/libnetcdf-feedstock#129

@dopplershift dopplershift mentioned this pull request Aug 25, 2021
Merged
3 tasks
@WardF
Copy link
Member

WardF commented Aug 25, 2021

Thanks @dopplershift I’ll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WardF WardF Awaiting requested review from WardF

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsjaardema @dopplershift @WardF