libnetcdf v4.8.1

[regro-cf-autotick-bot]

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

1. Feel free to push to the bot's branch to update this PR if needed.
2. The bot will almost always only open one PR per version.
   Checklist before merging this PR:

• Dependencies have been updated if changed: see upstream
• Tests have passed
• Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1151864474, please use this URL for debugging}

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :( Help is very welcome!

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[dopplershift]

@WardF @DennisHeimbigner The builds are failing due to:

CMake Error at dap4_test/baselinethredds/CMakeLists.txt:15 (FILE):
  FILE RENAME failed to rename

    /home/conda/feedstock_root/build_artifacts/libnetcdf_1629912619926/work/dap4_test/baselinethredds/GOES16_TEST1.nc4.thredds

  to

    /home/conda/feedstock_root/build_artifacts/libnetcdf_1629912619926/work/dap4_test/baselinethredds/GOES16_CONUS_20170821_020218_0.47_1km_33.3N_91.4W.nc4.thredds

  because: No such file or directory

This seems related to Unidata/netcdf-c#2077, but I'm not sure why it's breaking here but not netcdf-c's CI.

[DennisHeimbigner]

It occurs if you run the rename twice or run autoconf then cmake in same build.
Once the file is renamed, it is of course no longer available to be renamed again.
I was working on a simple fix for this which checks to make sure the rename has
not already occurred. Just have not put it up as a PR yet.

[dopplershift]

@DennisHeimbigner Ah, that makes sense. If you put up the PR, I'm happy to port here.

[DennisHeimbigner]

See Unidata/netcdf-c#2094.

[DennisHeimbigner]

The unzip dependency is not strictly necessary. It is being used to include
a directory tree as a test case. Is there a different equivalent that would
already be in the dependency list: tar or ar for example.

[dopplershift]

@WardF @DennisHeimbigner Ok, almost there. Now I'm seeing a Windows build failure:

CMake Error at CMakeLists.txt:813 (IF):
-- Configuring incomplete, errors occurred!
  if given arguments:

    "VERSION_GREATER" "1.10.5"

  Unknown arguments specified

[dopplershift]

Looks like Unidata/netcdf-c#2015 undid the change that was merged that made my patch superfluous. Time to put it back...

[ocefpaf]

I invited you to conda-forge so you would be here. My mission is complete! I will go back into the void now 😄

[dopplershift]

😆