Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path conversions for mingw-w64 #2084

Closed
wants to merge 2 commits into from

Conversation

mjwoods
Copy link
Contributor

@mjwoods mjwoods commented Aug 23, 2021

On mingw-w64 (32- or 64-bit), make check fails 48 tests because files are not found. This PR fixes the path conversions that cause the tests to fail.

@mjwoods mjwoods requested a review from WardF as a code owner August 23, 2021 05:03
@CLAassistant
Copy link

CLAassistant commented Aug 23, 2021

CLA assistant check
All committers have signed the CLA.

@DennisHeimbigner
Copy link
Collaborator

Interesting; I did not realize that mingw assumes windows style paths.
I suspect there are other places where some similar fix needs to be applied.
I will do some checking. But this fix will probably take care of most of the problems.
Thanks.

@mjwoods
Copy link
Contributor Author

mjwoods commented Jan 10, 2022

This issue has been resolved by 9380790 .

@mjwoods mjwoods closed this Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants