Use canonical path to derive name of dataset on Windows #2104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If #2084 is merged , netcdf utilities will use Windows paths on mingw-w64. This leads to problems in the output from
ncdump
, such as the following error fromdap4_test/test_meta.sh
:The default name of the dataset is supposed to be the basename of the input file, minus any file extension. The existing function
name_path
which determines the default dataset name assumes that paths have Unix directory separators (/
), but Windows paths use\\
. This PR produces a compatible path format using functionNCpathcanonical
instead ofNCpathcvt
.