Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pragma of PositionValue library should exclude 0.8.x #198

Closed
moodysalem opened this issue Sep 7, 2021 · 0 comments · Fixed by #201
Closed

Pragma of PositionValue library should exclude 0.8.x #198

moodysalem opened this issue Sep 7, 2021 · 0 comments · Fixed by #201
Assignees
@ewilz

Comments

@moodysalem
Copy link
Contributor

moodysalem commented Sep 7, 2021 •
edited
Loading

https://github.com/Uniswap/uniswap-v3-periphery/blob/ff3832f52d42a61df4513c1621dfbcfccd8a6d32/contracts/libraries/PositionValue.sol#L2

Our fee calculation code relies on unchecked math that is expected to overflow, need to restrict to <0.8.0 before publishing and explicitly document it
@ewilz ewilz mentioned this issue Sep 9, 2021
Merged
@jes16jupyter jes16jupyter mentioned this issue Apr 16, 2024
Open
ftofighi pushed a commit to ftofighi/v3-periphery that referenced this issue Nov 4, 2024
@NoahZinsmeister
Tick math tweaks (Uniswap#198)
c9c24b9 
* don't allow max price in getTickAtRatio

tickSpacing no longer has to be even

disallow unlimited contract size

* no max price
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewilz ewilz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PositionValue lib: restrict to lower than solc version 8 Uniswap/v3-periphery
2 participants
@ewilz @moodysalem