Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PositionValue lib: restrict to lower than solc version 8 #201

Merged
merged 2 commits into from
Sep 15, 2021

Conversation

ewilz
Copy link
Member

@ewilz ewilz commented Sep 9, 2021

fixes #198

@ewilz ewilz requested a review from moodysalem September 9, 2021 18:03
@moodysalem
Copy link
Contributor

what do we need in 0.7.0? would earlier versions work?

@ewilz
Copy link
Member Author

ewilz commented Sep 9, 2021

what do we need in 0.7.0? would earlier versions work?

hmm...well I see now our standard is to do from >=0.5.0 however, I use the TickMath library which uses type(uint256).max which is new in Solidity 0.6.8 even though TickMath also claims to compile from >=0.5.0 But I don't think it will compile lower than 0.6.8, (re PositionValue: unless dependencies are allowed to depend on higher versions?)

@ewilz ewilz changed the title PositionValue lib: restrict solc to version 7 PositionValue lib: restrict to lower than solc version 8 Sep 14, 2021
@ewilz
Copy link
Member Author

ewilz commented Sep 14, 2021

Changed to 0.6.8

@ewilz ewilz merged commit c56f98a into main Sep 15, 2021
@ewilz ewilz deleted the position_value_solc branch September 15, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pragma of PositionValue library should exclude 0.8.x
2 participants